Tests: Fix 22 warning in BuildCommandTests #8509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
pmattos
changed the title
|
@swift-ci please test |
|
@swift-ci test macos |
|
@swift-ci test self hosted windows |
|
@swift-ci test macOS |
jakepetroules
approved these changes
Apr 17, 2025
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Apr 17, 2025
### Motivation:
Reduce noise from solvable warnings.
### Modifications:
We should `throw XCTSkip("...")` but `try XCTSkipIf(true, "...")`.
The BuildCommandTests was mixing both (i.e., `try XCTSkip("...")`),
making the test a nop actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Reduce noise from solvable warnings.
Modifications:
We should
throw XCTSkip("...")buttry XCTSkipIf(true, "..."). TheBuildCommandTestswas mixing both (i.e.,try XCTSkip("...")), making the test a nop actually.Result:
Less 22 warnings I guess -:)