Tests: Run packageInitExecutable test on all platforms for native build system #8527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
|
@swift-ci test self hosted windows |
plemarquand
approved these changes
Apr 17, 2025
stmontgomery
approved these changes
Apr 17, 2025
plemarquand
approved these changes
Apr 18, 2025
|
@swift-ci test |
|
@swift-ci test self hosted windows |
jakepetroules
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Increase code coverage for our integration tests.
This is an issue I introduced in #8454 while ignoring
--build-system swiftbuildissues on Windows (i.e., actually this specific issue #8514). I accidentally skipped thepackageInitExecutabletest for--build-system nativeas well (which should be green). This PR fixes that.Modifications:
Swift Testing currently doesn't support combining conditional traits (e.g.,
skipHostOS(.windows)) with parametric tests — I double-checked with @stmontgomery. So the 2nd best approach is to split the tests as I just did.Result:
Slightly Increased test coverage for integration tests :-)