build-using-self use a self build of swift-test instead #8548
Conversation
We are seeing hangs in swift test on Windows. Instead of build-using-self using the underlying toolchain, build swift-test and use that for the tests. When we make improvements to it to fix the underlying problem, we will be able to take advantage of that fix right away.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
Also trying an idea on the test output hang we're seeing.
It's only supported there.
Use swift run to run build products. Try using a smaller buffer for the AsyncProcess reads to see if that helps.
We really need to do the pipe draining correctly. That will take a little more time. So for now, let's just turn off the tests on Windows until we get that resolved.
| @@ -144,31 +145,27 @@ def main() -> None: | |||
| shlex.split("swift --version"), | |||
| ) | |||
|
|
|||
| # call( | |||
There was a problem hiding this comment.
praise: It's always nice seeing commented code being removed!
| posix=(os.name == "posix"), # must be set correctly, otherwhsie shlex.split("C:\\Foo\\bar") become ['CFoobar'] | ||
| ), | ||
| ) | ||
| if os.name != "nt": # turn off for Windows until we get the hang resolved |
There was a problem hiding this comment.
Do we know what may be causing the hangs? It's quite coincidental the hangs started to occurs after the self hosted windows pipeline was changes from using the nightly toolchain, to the nightly 6.1 toolchain.
The self-hosted windows toolchain used the official docker image. should we try to see if the released 6.1 image has the same hangs?
There was a problem hiding this comment.
Yes, the 6.1 swiftpm has a bug in it. It's still there in 6.2. We should probably fix it.
| shlex.split(f"swift run swift-test --configuration {args.config} --parallel {swift_testing_arg} {xctest_arg} --scratch-path .test {ignore}"), | ||
| ) | ||
|
|
||
| integration_test_dir = REPO_ROOT_PATH / "IntegrationTests" |
There was a problem hiding this comment.
to make this code more robust to changes, it would be better to change the change_directory(REPO_ROOT_PATH context manager to return the directory, and use that path here instead of REPO_ROOT_PATH.
That is, change with change_directory(REPO_ROOT_PATH): to with change_directory(REPO_ROOT_PATH) as my_path: and then set integration_test_dir = my_path / "IntegrationTests" or just set it to a relative path (ie: integration_test_dir = Path("./IntegrationTests")
There was a problem hiding this comment.
We'll be back here to re-enable them on Windows. We can clean things up then. Let's just focus on re-enabling the Windows CI for now.
The code in SwiftSDK says it's SWIFT_CUSTOM_BIN_DIR.
We are seeing hangs in swift test on Windows. Instead of build-using-self using the underlying toolchain, build swift-test and use that for the tests. When we make improvements to it to fix the underlying problem, we will be able to take advantage of that fix right away.