[6.2] Use mergeable symbols in embedded #8757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
MaxDesiatov
added
embedded
|
Closing as superseded by #8754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8654.
Explanation: To workaround proper support for the Embedded Swift linkage model in SwiftPM, this PR updates the build plan to include -Xfrontend -mergeable symbols when building Embedded targets. This is a workaround/stop-gap solution until we can implement #8653. Fixes: #8648
Scope: limited to Embedded Swift support.
Risk: low due to limited scope.
Testing: New automated tests added to the test suite.
Issue: rdar://151021042
Reviewer: @dschaefer2