Skip to content

[Commands] SE-0481: Align the arguments to --target and `--to-featu… #8840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 18, 2025

…re` and allow a comma separated list

Motivation:

The Ecosystem Steering Group accepted SE-0486 with one modification - --target and --to-feature arguments should be comma separated - https://forums.swift.org/t/accepted-se-0486-migration-tooling-for-swift-features/80530.

Modifications:

  • Update MigrateOptions to accept comma separated strings for --target and --to-feature arguments.

Result:

The implementation is now aligned with the accepted proposal.

@xedin
Copy link
Contributor Author

xedin commented Jun 18, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jun 18, 2025

@swift-ci please test self hosted Windows platform

@bnbarham
Copy link
Contributor

IIRC we also updated add-setting, should we revert that change too?

@xedin
Copy link
Contributor Author

xedin commented Jun 19, 2025

I think it makes sense for add-setting to stay space separated for clarity since it has more structure in each argument.

@xedin
Copy link
Contributor Author

xedin commented Jun 19, 2025

@swift-ci please test Windows platform

xedin added a commit that referenced this pull request Jun 19, 2025
…featu… (#8841)

…re` and allow a comma separated list

---

- Explanation:

The Ecosystem Steering Group accepted SE-0486 with one modification -
`--target` and `--to-feature` arguments should be comma separated -
https://forums.swift.org/t/accepted-se-0486-migration-tooling-for-swift-features/80530.

- Main Branch PR:
#8840

- Risk: Very Low

- Reviewed By: @bnbarham 

- Testing: Command argument formatting change, no tests were added.

(cherry picked from commit 95214d0)
@xedin
Copy link
Contributor Author

xedin commented Jun 19, 2025

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Jun 19, 2025

@swift-ci please test self hosted Windows platform

@xedin xedin merged commit 18156e5 into swiftlang:main Jun 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants