fix deprecation to introduction for publicHeadersDirectoryURL property #8870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heckj
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
/cc @dschaefer2 - this is the one I reached out to @bripeticca about, if the deprecation is intended, happy to close this PR unmerged. |
|
@swift-ci please test |
|
Definitely looks like a cut/paste error. Thanks for spotting this! |
dschaefer2
approved these changes
Jun 25, 2025
|
The linux smoke test failure reported in CI should be resolved by #8871. |
jakepetroules
requested changes
Jun 25, 2025
There was a problem hiding this comment.
This change is not correct. The copy-paste error was that it was marked deprecated, but it does need the availability annotation to say that it was introduced in 6.0.
So the change on this line should be to change "deprecated" to "introduced". You can infer the original intent in #7184 where the property was introduced.
|
@jakepetroules thanks! I'll update! |
|
@swift-ci please test |
heckj
changed the title
jakepetroules
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation looks "incorrect" as it was added and deprecated at the same as the property
publicHeadersDirectory, which I believe this was meant to replace.Motivation:
While updating the documentation, this stood out as added and deprecated, which seemed like a mistake.
Modifications:
reverted the deprecation of the publicHeadersDirectoryURL property
Result:
property is undeprecated