SwiftBuild: Enable traits support #8873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
bkhouri
commented
Jun 25, 2025
There was a problem hiding this comment.
This file is better reviewed while ignoring whitespaces.
owenv
approved these changes
Jun 25, 2025
bripeticca
approved these changes
Jun 25, 2025
jakepetroules
approved these changes
Jun 25, 2025
bkhouri
force-pushed
the
t/main/get_trait_supported_with_swift_build
branch
2 times, most recently
from
d7f25af to
d2d0d1f
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/get_trait_supported_with_swift_build
branch
from
d2d0d1f to
84df920
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/get_trait_supported_with_swift_build
branch
from
84df920 to
29d4840
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test self hosted |
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/get_trait_supported_with_swift_build
branch
from
29d4840 to
4ea0898
Compare
|
@swift-ci test |
When Creasting the SwiftBuildSystem Factory, the traits configuration was not passed when loading the package graph. Update the factory to pass the traits configuration during package resolution, and remove the `withKnownIssues` in TraitTests as it relates to SwiftBuild. Also augment te tests to run against all build configuration.
bkhouri
force-pushed
the
t/main/get_trait_supported_with_swift_build
branch
from
4ea0898 to
8c2fb47
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Creasting the SwiftBuildSystem Factory, the traits configuration was not passed when loading the package graph.
Update the factory to pass the traits configuration during package resolution, and remove the
withKnownIssuesin TraitTests as it relates to SwiftBuild.There are some know issues, which are tracked via the automated tests.