Enable Swift 6 mode when available, sync QueryEngine sources
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As SwiftPM is more actively developed, let's consider it to be the source of truth and vendor it back into `swift-sdk-generator` together with more fresh `AsyncFileSystem` code. This allows us to fix concurrency errors that prevent it from building in Swift 6 mode.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
Let me check 5.8 compatibility before merging |
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 28, 2024
This expands available `AsyncFileSystem` APIs and brings them in sync with `swift-sdk-generator` as implemented in swiftlang/swift-sdk-generator#136.
|
@MaxDesiatov We need this change against AsyncFileSystem to keep 5.8 compatibility. swiftlang/swift-package-manager#7928 |
MaxDesiatov
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 29, 2024
AsyncFileSystem is going to be vendored into swift-sdk-generator (swiftlang/swift-sdk-generator#136), and the tool is built with bootstrapping toolchain that is Swift 5.8 on ci.swift.org. This commit makes the vendored AsyncFileSystem compatible with Swift 5.8 by avoiding the use of SE-0380.
|
@swift-ci test |
|
@kateinoigakukun done, ready for review |
kateinoigakukun
approved these changes
Aug 29, 2024
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Sep 20, 2024
This expands available `AsyncFileSystem` APIs and brings them in sync with `swift-sdk-generator` as implemented in swiftlang/swift-sdk-generator#136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As SwiftPM is more actively developed, let's consider it to be the source of truth and vendor
QueryEngineback intoswift-sdk-generatortogether with more freshAsyncFileSystemcode, storing all those files inSource/Helpers/Vendorsubdirectory.All this allows us to fix concurrency errors that prevent it from building in Swift 6 mode.