generator: Quote paths passed to container image extraction commands #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some paths were being passed to container extraction commands (tar, docker cp) without quotes. This caused the extraction to fail if the paths contained spaces.
euanh
force-pushed
the
quote-container-extraction-paths
branch
from
4d43be6 to
25e3dfe
Compare
MaxDesiatov
approved these changes
Feb 4, 2025
|
@swift-ci test |
|
I wonder if a type with custom string interpolation could insert quotes automatically? Totally fine to tackle in a future PR if you think that's a sensible idea at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some paths were being passed to container extraction commands (tar, docker cp) without quotes. This caused the extraction to fail if the paths contained spaces.