Skip to content

CI: Add support for GitHub Actions #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 10, 2025
Merged

CI: Add support for GitHub Actions #199

merged 19 commits into from
Mar 10, 2025

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal requested a review from MaxDesiatov as a code owner March 10, 2025 03:36
@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author 

Test Case 'RepeatedBuildTests.testRepeatedSDKBuilds' started at 2025-03-10 05:46:37.228
2025-03-10T05:46:37+0000 warning swift-sdk-generator : [SwiftSDKGeneratorTests] Docker CLI does not seem to be working, skipping tests that involve Docker.
2025-03-10T05:46:37+0000 info swift-sdk-generator : temporaryDirectory=/tmp/DE100F96-B55D-4DB2-B954-31D9C526FAFE testcase=testRepeatedSDKBuilds [SwiftSDKGeneratorTests] Created temporary directory
2025-03-10T05:46:37+0000 info swift-sdk-generator : runArguments="--host-toolchain" scratchPath=/tmp/DE100F96-B55D-4DB2-B954-31D9C526FAFE testcase=testRepeatedSDKBuilds [SwiftSDKGeneratorTests] Building SDK
2025-03-10T05:48:40+0000 info swift-sdk-generator : temporaryDirectory=/tmp/DE100F96-B55D-4DB2-B954-31D9C526FAFE testcase=testRepeatedSDKBuilds [SwiftSDKGeneratorTests] Removed temporary directory
/bin/sh: 1: docker: not found
<EXPR>:0: error: RepeatedBuildTests.testRepeatedSDKBuilds : threw error "process exited non-zero: exit(1)"
Test Case 'RepeatedBuildTests.testRepeatedSDKBuilds' failed (123.734 seconds)

cc: @MaxDesiatov

@euanh euanh self-requested a review March 10, 2025 09:00
@euanh
Copy link
Contributor

euanh commented Mar 10, 2025

@shahmishal @MaxDesiatov The unit and integration tests in this repository are quite complicated so I think it's best to try to get the basic soundness checks running first.

@MaxDesiatov
Copy link
Contributor

@swift-ci test

MaxDesiatov
MaxDesiatov reviewed Mar 10, 2025
View reviewed changes
MaxDesiatov and others added 11 commits March 10, 2025 09:48
@MaxDesiatov
Update .github/workflows/pull_request.yml
61e4df6
@MaxDesiatov
Unify license headers
e7323a8
@MaxDesiatov
Update license_header_check_project_name in workflow
599634e
@MaxDesiatov
Use .license_header_template
de884a5
@MaxDesiatov
Fix most of the license checks
b51ecc8
@MaxDesiatov
Update .licenseignore
c7d0e3e
@MaxDesiatov
Fix .licenseignore
c1fe156
@euanh
workflows: Fix multiline string formatting for swift-format
164d34a
@euanh
workflows: Allow swift-format to fix whitespace
96c32fa
@euanh
workflows: Snapshot default swift-format settings
f541364 
The .swift-format settings file was generated by:

   swift format dump-configuration > .swift-format

We will need to configure or turn off some checks;  this allows us to
keep track of what settings we have changed.
@euanh
workflows: Disable invasive swift-format checks
3094b76 
swift format complains about some long-standing choices in this repository.
For now we will disable these specific complaints.
@euanh
Copy link
Contributor

euanh commented Mar 10, 2025

@swift-ci test

@euanh
Copy link
Contributor

euanh commented Mar 10, 2025

@swift-ci test

@euanh euanh requested a review from MaxDesiatov March 10, 2025 11:23
@MaxDesiatov MaxDesiatov changed the title [CI] Add support for GitHub Actions CI: Add support for GitHub Actions Mar 10, 2025
@MaxDesiatov MaxDesiatov added the continuous integration Changes to CI workflows label Mar 10, 2025
@MaxDesiatov MaxDesiatov merged commit 5fee508 into main Mar 10, 2025
12 checks passed
@MaxDesiatov MaxDesiatov deleted the github-actions-support branch March 10, 2025 11:25
@euanh euanh mentioned this pull request Mar 10, 2025
Merged
euanh added a commit to euanh/swift-sdk-generator that referenced this pull request Apr 16, 2025
@euanh
docs: Delete instructions to run non-existent soundness.sh
7778bc8 
Utilities/soundness.sh was deleted in swiftlang#199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
@euanh euanh mentioned this pull request Apr 16, 2025
Merged
euanh added a commit to euanh/swift-sdk-generator that referenced this pull request Apr 16, 2025
@euanh
docs: Delete instructions to run non-existent soundness.sh
9d9f78d 
Utilities/soundness.sh was deleted in swiftlang#199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
MaxDesiatov pushed a commit that referenced this pull request Apr 16, 2025
@euanh
docs: Delete instructions to run non-existent soundness.sh (#206)
9fe010c 
Utilities/soundness.sh was deleted in #199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euanh euanh Awaiting requested review from euanh

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

Assignees
No one assigned
Labels
continuous integration Changes to CI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @euanh @MaxDesiatov