Skip to content

Add 4.0 commits: JSQCoreDataKit, JSQDataSourcesKit #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Add 4.0 commits: JSQCoreDataKit, JSQDataSourcesKit #126

merged 1 commit into from
Jan 9, 2018

Conversation

jessesquires
Copy link
Contributor

@jessesquires jessesquires commented Jan 1, 2018

Pull Request Description

Adds 4.0 commits for JSQCoreDataKit and JSQDataSourcesKit

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 3.0 compatibility mode
    and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@lplarson
Copy link
Contributor

lplarson commented Jan 3, 2018

@swift-ci test

4 similar comments
@lplarson
Copy link
Contributor

lplarson commented Jan 3, 2018

@swift-ci test

@lplarson
Copy link
Contributor

lplarson commented Jan 4, 2018

@swift-ci test

@lplarson
Copy link
Contributor

lplarson commented Jan 6, 2018

@swift-ci test

@lplarson
Copy link
Contributor

lplarson commented Jan 9, 2018

@swift-ci test

@lplarson
Copy link
Contributor

lplarson commented Jan 9, 2018

@jessesquires Thanks!

@lplarson lplarson merged commit 751f0f9 into swiftlang:master Jan 9, 2018
@jessesquires jessesquires deleted the patch-1 branch January 9, 2018 23:42
@jessesquires
Copy link
Contributor Author

Thanks @lplarson ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants