Remove tests that fail with Swift 3 expression type checking support … #197
Conversation
…removed. Most of these are tested with 4.x as well, and remain. I've wholesale deleted the ones that are only tested with 3.x, but could revert those parts of XFAIL them instead if there is a reason to do so. My thoughts are that it's easy to replace these when we get hashes to text 4.x with.
|
@swift-ci Please test |
|
@clackary I can certainly XFAIL these instead, but they are definitely not going to build with 4.2 with the current hashes (they all fail due to Swift 3-specific changes being removed in swiftlang/swift#17691). Note that |
|
@clackary Let me know if you think it's worth XFAILing. If I do that I will need one or more JIRAs to reference for the tests that are XFAILed. |
|
@rudkx I think it is worth XFAILing. I think there's an expectation to at least notify maintainers and give them a chance to update it before their project is removed. |
moment to disable the ones that do not build with expression type checking support for Swift 3 removed.
|
@clackary Okay, updated to XFAIL instead (except for the project that had two entries, where I've now removed the 3.0 one). |
|
@swift-ci Please test |
|
@swift-ci Please test |
|
The failures are all UPASSes for the tests that have been XFAILed but which do not fail without my compiler PR (swiftlang/swift#17691). |
|
Please test with following pull request: @swift-ci Please test |
|
Most of these were covered by #210 and other PRs. I'll open a new PR for anything else that is still blocking my compiler PR. |
rudkx
deleted the
remove-swift-3-tests-that-fail-with-typechecker-changes
branch
…removed.
Most of these are tested with 4.x as well, and remain. I've wholesale
deleted the ones that are only tested with 3.x, but could revert those
parts of XFAIL them instead if there is a reason to do so. My thoughts
are that it's easy to replace these when we get hashes to text 4.x with.