Skip to content

Enable CoreStore tvOS project #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2018
Merged

Enable CoreStore tvOS project #208

merged 2 commits into from
Jul 6, 2018

Conversation

shahmishal
Copy link
Member

After updating the bots to Xcode 10 beta 3, we started seeing CoreStore tvOS project passing again.

https://bugs.swift.org/browse/SR-7908

@shahmishal
Copy link
Member Author

@swift-ci test

clackary
clackary reviewed Jul 6, 2018
View reviewed changes
projects.json Outdated
@@ -378,22 +378,6 @@
"scheme": "CoreStore tvOS",
"destination": "generic/platform=tvOS",
"configuration": "Release",
Copy link
Contributor

@clackary clackary Jul 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal I think this trailing comma might cause problems

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

Looks good:

PASS: CoreStore, 3.2, e314db, CoreStoreDemo, generic/platform=iOS
PASS: CoreStore, 4.0, 83e608, CoreStore iOS, generic/platform=iOS
PASS: CoreStore, 4.0, 83e608, CoreStore OSX, generic/platform=macOS
PASS: CoreStore, 4.0, 83e608, CoreStore tvOS, generic/platform=tvOS
XFAIL: https://bugs.swift.org/browse/SR-7908, CoreStore, 4.0, 83e608, CoreStore watchOS, generic/platform=watchOS

@shahmishal
Copy link
Member Author

Going to merge it to unblock CI.

@shahmishal shahmishal merged commit a48a828 into master Jul 6, 2018
@shahmishal shahmishal deleted the enable-corestore-tvos branch July 6, 2018 20:02
@shahmishal shahmishal mentioned this pull request Jul 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clackary clackary clackary left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @clackary