Skip to content

[Workaround] Use old build system, avoid clean build issue #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2018
Merged

[Workaround] Use old build system, avoid clean build issue #213

merged 3 commits into from
Jul 11, 2018

Conversation

clackary
Copy link
Contributor

Pull Request Description

Reverts #212 as it did not seem to resolve the issue. It looks like this change needed to land on project_future.py, because runner.py imports project_future.py, not project.py.

Clack Cole added 2 commits July 10, 2018 15:40
Revert "[Workaround] Use old build system, due to issue with clean bu…
ee55026 
…ild"

This reverts commit 7dd165b.
[Workaround] Use old build system
ddf4064 
This avoids an issue when trying to do a clean build
@clackary
Copy link
Contributor Author

@swift-ci test

@clackary clackary changed the title Workaround clean build folder [Workaround] Use old build system, avoid clean build issue Jul 11, 2018
@clackary
Copy link
Contributor Author

Seems to be the same failures as the other PR...

20:39:47 ========================================
20:39:47 Failures:
20:39:47   FAIL: BeaconKit, 4.0.3, 189b40, Swift Package
20:39:47   FAIL: BeaconKit, 4.0, 189b40, Swift Package
20:39:47   FAIL: BeaconKit, 3.1, 189b40, Swift Package
20:39:47   FAIL: Deferred, 4.0, 190f44, Swift Package
20:39:47   FAIL: Deferred, 3.2, 190f44, Swift Package
20:39:47   FAIL: GRDB.swift, 4.0, f121c6, Swift Package
20:39:47   FAIL: Lark, 4.0, 7604f9, Swift Package
20:39:47   FAIL: Lark, 3.0, 017928, Swift Package
20:39:47   FAIL: Moya, 4.0.3, 4b3ff7, Swift Package
20:39:47   FAIL: NetService, 4.0, 51256c, Swift Package
20:39:47   FAIL: NetService, 3.1, 4c20bd, Swift Package
20:39:47   FAIL: Perfect, 3.0, 540feb, Swift Package
20:39:47   FAIL: Plank, 4.0.3, fe7841, Swift Package
20:39:47   FAIL: R.swift, 4.0, c5273e, Swift Package
20:39:47   FAIL: R.swift, 3.0, ac56b8, Swift Package
20:39:47   FAIL: Result, 4.0, 747758, Swift Package
20:39:47   FAIL: Result, 3.1, 1a2a97, Swift Package
20:39:47   FAIL: SwiftLint, 4.0, 549d4c, Swift Package
20:39:47 ========================================

This was referenced Jul 11, 2018
Merged
Merged
@jrose-apple
Copy link
Contributor

Those should be unrelated, since they're all building with SwiftPM. It's still worth taking this if it brings the number of failing projects down.

Adds xfails to failing package manager projects
e3d7df0 
https://bugs.swift.org/browse/SR-8234

Several tests are failing in CI for issues related to Package.swift,
this change xfails them to unblock CI and PR testing. It also cleans
up some older hashes that are either redundant or no longer
supported.
@clackary
Copy link
Contributor Author

@swift-ci test

@clackary clackary merged commit 8fe2686 into master Jul 11, 2018
@clackary clackary deleted the workaround-clean-build-folder branch July 11, 2018 21:05
clackary pushed a commit that referenced this pull request Jul 12, 2018
Also xfail Swift Package builds on 4.2
fa56824 
https://bugs.swift.org/browse/SR-8234

See also #213
@clackary clackary mentioned this pull request Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clackary @jrose-apple