Skip to content

Refactor common leading arguments out and add --distcc. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

Refactor common leading arguments out and add --distcc. #235

merged 1 commit into from
Aug 16, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Aug 15, 2018

If '--distcc' is passed in, use it in the invocation of build-script.

@rudkx
Refactor common leading arguments out and add --distcc.
b3f0f6b 
If '--distcc' is passed in, use it in the invocation of build-script.
@rudkx rudkx requested a review from clackary August 15, 2018 23:45
@rudkx
Copy link
Contributor Author

rudkx commented Aug 15, 2018

@swift-ci Please test

@shahmishal shahmishal self-requested a review August 16, 2018 00:16
shahmishal
shahmishal approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

clackary
clackary approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for cleaning up the common args.

@rudkx rudkx merged commit 3a70b9a into swiftlang:master Aug 16, 2018
@rudkx rudkx deleted the add-distcc branch August 16, 2018 02:12
@rudkx rudkx restored the add-distcc branch August 23, 2018 19:34
@rudkx rudkx deleted the add-distcc branch August 23, 2018 19:34
@rudkx rudkx restored the add-distcc branch August 23, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@clackary clackary clackary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudkx @shahmishal @clackary