Skip to content

Update Then hash to build against 4.2 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Update Then hash to build against 4.2 #242

merged 2 commits into from
Sep 11, 2018

Conversation

clackary
Copy link
Contributor

@clackary clackary commented Sep 11, 2018

Pull Request Description

Updates the hash to a recent commit, and also updates the configuration to build against Swift 4.2. Also removes the xfail from https://bugs.swift.org/browse/SR-8250.

Acceptance Criteria

  • pass ./project_precommit_check script run
./project_precommit_check Then --earliest-compatible-swift-version 4.2
** CHECK **
--- Validating Then Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking Then platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcodes/Xcode_10_Beta_6.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ ./runner.py --swift-branch swift-4.2-branch --swiftc /Applications/Xcodes/Xcode_10_Beta_6.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects projects.json --include-repos 'path == "Then"' --include-versions 'version == "4.2"' --include-actions 'action.startswith("Build")'
PASS: Then, 4.2, 3edb1c, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- Then checked successfully against Swift 4.2 ---

Ensure project meets all listed requirements before submitting a pull request.

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@swift-ci test

1 similar comment
@clackary
Copy link
Contributor Author

@swift-ci test

@clackary clackary merged commit 14287b6 into master Sep 11, 2018
@clackary clackary deleted the update-then branch September 11, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant