Skip to content

Update Surge to Swift 4 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Update Surge to Swift 4 #276

merged 2 commits into from
Oct 30, 2018

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

We need to update scheme of the project to be

Schemes:
        Surge-iOS
        Surge-macOS
        Surge-tvOS
        Surge-watchOS

@clackary
Copy link
Contributor

Yep, running a test locally to verify schemes are correct.

@shahmishal
Copy link
Member Author

@swift-ci test

Copy link
Contributor

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like project_precommit_check passes with these changes. Thanks!

./project_precommit_check Surge --earliest-compatible-swift-version 4.2
** CHECK **
--- Validating Surge Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking Surge platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ ./runner.py --swift-branch swift-4.2-branch --swiftc /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects projects.json --include-repos 'path == "Surge"' --include-versions 'version == "4.2"' --include-actions 'action.startswith("Build")'
PASS: Surge, 4.2, 38a328, Surge-iOS, generic/platform=iOS
PASS: Surge, 4.2, 38a328, Surge-tvOS, generic/platform=tvOS
PASS: Surge, 4.2, 38a328, Surge-watchOS, generic/platform=watchOS
PASS: Surge, 4.2, 38a328, Surge-macOS, generic/platform=macOS
========================================
Action Summary:
     Passed: 4
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 4
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- Surge checked successfully against Swift 4.2 ---

@clackary clackary merged commit f1d20dd into master Oct 30, 2018
@clackary clackary deleted the update-Surge branch October 30, 2018 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants