Skip to content

Update ProcedureKit to build against Swift 4.2 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

clackary
Copy link
Contributor

Pull Request Description

Also add xfail of ProcedureKitCloud due to https://bugs.swift.org/browse/SR-9139

  • pass ./project_precommit_check script run
$ ./project_precommit_check ProcedureKit --earliest-compatible-swift-version 4.2
** CHECK **
--- Validating ProcedureKit Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking ProcedureKit platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ ./runner.py --swift-branch swift-4.2-branch --swiftc /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects projects.json --include-repos 'path == "ProcedureKit"' --include-versions 'version == "4.2"' --include-actions 'action.startswith("Build")'
PASS: ProcedureKit, 4.2, 94193d, ProcedureKit, platform=macOS
PASS: ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=iOS
PASS: ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=watchOS
PASS: ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=tvOS
XFAIL: https://bugs.swift.org/browse/SR-9139, ProcedureKit, 4.2, 94193d, ProcedureKitCloud, platform=macOS
========================================
XFailures:
  XFAIL: https://bugs.swift.org/browse/SR-9139, ProcedureKit, 4.2, 94193d, ProcedureKitCloud, platform=macOS
========================================
Action Summary:
     Passed: 4
     Failed: 0
    XFailed: 1
    UPassed: 0
      Total: 5
========================================
Repository Summary:
      Total: 1
========================================
Result: XFAIL
========================================
--- ProcedureKit checked successfully against Swift 4.2 ---

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary clackary merged commit 9afb0ee into master Oct 30, 2018
@clackary clackary deleted the update-procedurekit branch October 30, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant