[Add] PlanGrid/ReactiveLists #288

jessesquires · 2018-11-09T19:24:50Z

Pull Request Description

Adds ReactiveLists to the suite, which is used in the PlanGrid iOS app.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

Ensure project meets all listed requirements before submitting a pull request.

clackary

Thanks for the pull request! Were you able to run project_precommit_check here? When I try to run it, I see it fail with errors like this:

/tmp/swift-source-compat-suite/project_cache/ReactiveLists/Sources/CollectionViewDriver.swift:105:130: error: 'elementKindSectionHeader' has been renamed to 'UICollectionElementKindSectionHeader'
        let visibleIndexPathsForHeaders = self.collectionView.indexPathsForVisibleSupplementaryElements(ofKind: UICollectionView.elementKindSectionHeader)
                                                                                                                                 ^~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                                 UICollectionElementKindSectionHeader

This seems to be coming from commit 7811400. It passed when rolling back to 65ab055.

Also, would you mind moving this configuration to be between the entires for ReactiveCocoa and ReactiveSwift?

clackary · 2018-11-26T18:01:18Z

projects.json

+      {
+        "action": "BuildXcodeWorkspaceScheme",
+        "workspace": "ReactiveLists.xcworkspace",
+        "target": "ReactiveLists",


Since you're using a workspace here, we want to build a scheme instead of a target.

Suggested change

"target": "ReactiveLists",

"scheme": "ReactiveLists",

clackary · 2018-11-26T22:18:54Z

Quick update: looks like this might be coming from the way we handle some xcodebuild flags. The project does indeed seem to build correctly with Swift 4.2. I'm looking into this, but we'll still want to make the two changes I suggested in the review.

clackary · 2018-11-27T00:26:19Z

I've opened #292 to address this.

jessesquires · 2018-11-29T01:04:37Z

Thanks @clackary !

I've updated the PR with the changes requests.

The output of running:

 ./project_precommit_check ReactiveLists --earliest-compatible-swift-version 4.2

** CHECK **
--- Validating ReactiveLists Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking ReactiveLists platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check failed ---
Expected version:
Apple Swift version 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1)
Target: x86_64-apple-darwin17.7.0

Current version:
Apple Swift version 4.2.1 (swiftlang-1000.11.42 clang-1000.11.45.1)
Target: x86_64-apple-darwin18.2.0

error: please select Xcode 10.0 (contains Swift 4.2)

Looks like we need to set some Xcode project settings for Swift 4.2?

clackary · 2018-11-30T19:18:14Z

Ah, since you're checking something against Swift 4.2, you'd need to have Xcode 10 installed and selected. You appear to have Xcode 10.1 installed, which technically contains Swift 4.2.1. Not a huge deal. I'll start another round of testing.

Thanks for making those changes!

jessesquires · 2018-11-30T19:53:23Z

Awesome. Thanks @clackary ! 🙌

clackary · 2018-11-30T20:03:11Z

@swift-ci test

clackary · 2018-12-03T19:43:19Z

From the build log, it looks like it's failing when trying to run swiftlint from a script in the xcodeproj.

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/ReactiveLists/build/Build/Intermediates.noindex/ReactiveLists.build/Release-iphoneos/ReactiveLists.build/Script-357B96DD20193EB50000443F.sh: line 2: 26488 Abort trap: 6           ${PODS_ROOT}/SwiftLint/swiftlint

I found the corresponding script in ReactiveLists sources.

This might be coming from an interaction with the sandbox. Network activity is blocked during build time. Maybe SwiftLint is trying to install during build?

jessesquires · 2018-12-03T19:46:48Z

@clackary Hm... it shouldn't be trying to install. We install via CocoaPods and check-in Pods/...

I'll investigate.

jessesquires · 2019-03-19T23:34:39Z

hey @clackary sorry for the delay here! Just updated this PR.

I think it's ok. But the project_precommit_check script still gives me the same error that I mentioned in the comment above. I'm using Xcode 10.1 (10B61)

clackary · 2019-03-25T23:16:02Z

@swift-ci please test

clackary · 2019-03-25T23:16:16Z

@jessesquires Sounds good, thanks for the update.

clackary · 2019-03-27T21:20:58Z

The build log shows a few failures related to StagedChangeset...

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/ReactiveLists/Pods/DifferenceKit/Sources/StagedChangeset.swift:46:1: error: type 'StagedChangeset<Collection>' does not conform to protocol 'Sequence'
extension StagedChangeset: RandomAccessCollection, RangeReplaceableCollection, MutableCollection {
^

jessesquires · 2019-03-27T22:13:20Z

@clackary Ah, that's expected for Xcode 10.2.

I just updated the library to Swift 5, so I'll update the PR for that.

jessesquires · 2019-03-27T22:14:45Z

Or, put another way: it should build with Xcode 10.1, but breaks with Xcode 10.2 (even in 4.2 mode)

jessesquires · 2019-03-27T22:16:07Z

Updated!

clackary · 2019-03-27T22:18:09Z

@swift-ci test

clackary · 2019-03-28T18:09:29Z

@swift-ci test

clackary · 2019-07-02T23:57:55Z

@swift-ci test

clackary · 2019-07-03T00:02:01Z

The build results there are a few months stale, so I ran a local test against Xcode 11 beta 3, and I expect this to pass now.

clackary · 2019-07-03T21:04:35Z

Build failed because of an issue with SwiftLint...

    /bin/sh -c /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/ReactiveLists/build/Build/Intermediates.noindex/ReactiveLists.build/Release-iphoneos/ReactiveLists.build/Script-357B96DD20193EB50000443F.sh
/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/ReactiveLists/build/Build/Intermediates.noindex/ReactiveLists.build/Release-iphoneos/ReactiveLists.build/Script-357B96DD20193EB50000443F.sh: line 2: 65310 Segmentation fault: 11  ${PODS_ROOT}/SwiftLint/swiftlint
Command PhaseScriptExecution failed with a nonzero exit code

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution SwiftLint /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/ReactiveLists/build/Build/Intermediates.noindex/ReactiveLists.build/Release-iphoneos/ReactiveLists.build/Script-357B96DD20193EB50000443F.sh
(1 failure)

clackary · 2019-07-04T00:07:18Z

Oh, this is the same thing we were hitting before?

jessesquires · 2019-07-08T21:43:07Z

cc @anayini @ronaldsmartin -- either of you interested in carrying this PR forward?

jessesquires · 2019-09-24T21:08:42Z

going to close. i don't have time to fix.

cc @anayini @ronaldsmartin

[Add] PlanGrid/ReactiveLists

71ecbf7

clackary requested changes Nov 26, 2018

View reviewed changes

address PR feedback

9052b57

clackary approved these changes Nov 30, 2018

View reviewed changes

Update projects.json

014b663

point to swift 5.0 commit

365f0d9

jessesquires closed this Sep 24, 2019

[Add] PlanGrid/ReactiveLists #288

[Add] PlanGrid/ReactiveLists #288

Uh oh!

Conversation

jessesquires commented Nov 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Acceptance Criteria

Uh oh!

clackary left a comment

Choose a reason for hiding this comment

Uh oh!

clackary Nov 26, 2018

Choose a reason for hiding this comment

Uh oh!

clackary commented Nov 26, 2018

Uh oh!

clackary commented Nov 27, 2018

Uh oh!

jessesquires commented Nov 29, 2018

Uh oh!

clackary commented Nov 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jessesquires commented Nov 30, 2018

Uh oh!

clackary commented Nov 30, 2018

Uh oh!

clackary commented Dec 3, 2018

Uh oh!

jessesquires commented Dec 3, 2018

Uh oh!

jessesquires commented Mar 19, 2019

Uh oh!

clackary commented Mar 25, 2019

Uh oh!

clackary commented Mar 25, 2019

Uh oh!

clackary commented Mar 27, 2019

Uh oh!

jessesquires commented Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jessesquires commented Mar 27, 2019

Uh oh!

jessesquires commented Mar 27, 2019

Uh oh!

clackary commented Mar 27, 2019

Uh oh!

clackary commented Mar 28, 2019

Uh oh!

clackary commented Jul 2, 2019

Uh oh!

clackary commented Jul 3, 2019

Uh oh!

clackary commented Jul 3, 2019

Uh oh!

clackary commented Jul 4, 2019

Uh oh!

jessesquires commented Jul 8, 2019

Uh oh!

jessesquires commented Sep 24, 2019

Uh oh!

Uh oh!

jessesquires commented Nov 9, 2018 •

edited

Loading

clackary commented Nov 30, 2018 •

edited

Loading

jessesquires commented Mar 27, 2019 •

edited

Loading