Skip to content

Revert "Keep ModelAssistant XFAILed on swift-5.0-branch." #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Revert "Keep ModelAssistant XFAILed on swift-5.0-branch." #298

merged 1 commit into from
Dec 5, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Dec 4, 2018

Un-XFAIL ModelAssistant on the swift-5.0-branch once
swiftlang/swift#20971 is merged.

Un-XFAIL ModelAssistant on the swift-5.0-branch once
swiftlang/swift#20971 is merged.
@rudkx rudkx changed the title [WIP] Revert "Keep ModelAssistant XFAILed on swift-5.0-branch." Revert "Keep ModelAssistant XFAILed on swift-5.0-branch." Dec 5, 2018
@rudkx rudkx requested a review from clackary December 5, 2018 19:05
@rudkx
Copy link
Contributor Author

rudkx commented Dec 5, 2018

@swift-ci Please test

Copy link
Contributor

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudkx rudkx merged commit 25fe4d7 into swiftlang:master Dec 5, 2018
@rudkx rudkx deleted the unxfail-model-assistant-swift-5.0-branch branch December 5, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants