Skip to content

XFAIL projects using non-stdlib Result #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 13, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Dec 12, 2018

@moiseev
Copy link
Contributor Author

moiseev commented Dec 12, 2018

@swift-ci please test

@moiseev
Copy link
Contributor Author

moiseev commented Dec 13, 2018

@swift-ci please test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci please test

@moiseev
Copy link
Contributor Author

moiseev commented Dec 13, 2018

Vapor failure is unrelated to Result.

16/16] /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/build/compat_macos/install/toolchain/usr/bin/swiftc -module-name Routing -incremental -emit-dependencies -emit-module -emit-module-path /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/Routing.swiftmodule -output-file-map /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/Routing.build/output-file-map.json -parse-as-library -whole-module-optimization -num-threads 24 -c /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Parameter/Parameter.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Parameter/ParameterValue.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Parameter/Parameters.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Register/PathComponent.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Register/Route.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Register/RouterOption.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Routing/RoutableComponent.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Routing/RouterNode.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Routing/TrieRouter.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Utilities/Deprecated.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Utilities/Exports.swift /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Utilities/RoutingError.swift -I /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release -target x86_64-apple-macosx10.10 -swift-version 4 -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -F /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -O -j24 -DSWIFT_PACKAGE -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOSHA1.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOSHA1/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOAtomics.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOAtomics/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIODarwin.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIODarwin/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/CNIOLinux.build/module.modulemap -I /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/checkouts/swift-nio-b68c973e/Sources/CNIOLinux/include -Xcc -fmodule-map-file=/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/checkouts/swift-nio-zlib-support-c4b8a10c/module.modulemap -module-cache-path /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/.build/x86_64-apple-macosx/release/ModuleCache
/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/vapor_routing/Sources/Routing/Routing/TrieRouter.swift:77:29: error: ambiguous use of 'withUnsafeBytes'
                if constant.value.withUnsafeBytes({ path.routerCompare(to: $0, options: options) }) {
                            ^
Foundation.Data:42:28: note: found this candidate
    @inlinable public func withUnsafeBytes<ResultType>(_ body: (UnsafeRawBufferPointer) throws -> ResultType) rethrows -> ResultType
                           ^
NIOFoundationCompat.Data:2:28: note: found this candidate
    @inlinable public func withUnsafeBytes<R>(_ body: (UnsafeRawBufferPointer) throws -> R) rethrows -> R
                           ^

@moiseev
Copy link
Contributor Author

moiseev commented Dec 13, 2018

@swift-ci please test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci please test

@shahmishal
Copy link
Member

@moiseev Is it ok If I merge this to unblock CI?

@shahmishal shahmishal merged commit 7c98bda into swiftlang:master Dec 13, 2018
@moiseev moiseev deleted the xfail-result-breakage branch December 13, 2018 19:29
@DougGregor
Copy link
Member

Thanks @shahmishal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants