[Add] ACHNBrowserUI

[Dimillian]

Pull Request Description

Add ACHNBrowserUI a full featured SwiftUI application

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

• be an Xcode or swift package manager project
• support building on either Linux or macOS
• target Linux, macOS, or iOS/tvOS/watchOS device
• be contained in a publicly accessible git repository
• maintain a project branch that builds against Swift 4.0 and passes any unit tests
• have maintainers who will commit to resolve issues in a timely manner
• be compatible with the latest GM/Beta versions of Xcode and swiftpm
• add value not already included in the suite
• be licensed with one of the following permissive licenses:
  • BSD
  • MIT
  • Apache License, version 2.0
  • Eclipse Public License
  • Mozilla Public License (MPL) 1.1
  • MPL 2.0
  • CDDL
• pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

[clackary]

@swift-ci test

[Dimillian]

Anything I should do?

[clackary]

Ah, this isn't related to your changes at all. Restarting testing.

[clackary]

@swift-ci test

[varungandhi-apple]

@swift-ci test

[varungandhi-apple]

It's the silly header error again, ugh.

'/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator13.4.sdk/usr/include/AvailabilityInternal.h': Operation not permitted
#include <AvailabilityInternal.h>
         ^

I thought that was already fixed. Let's see what we can do here...

Btw, is there a typo in the name (ACHNBrowserUI instead of ACNHBrowserUI)?

[Dimillian]

Busted.... yes I’ve made a typo when I created the repository and the project and now it’s too late haha...

[varungandhi-apple]

I think this has been fixed; bunch of PRs against apple/swift are passing, instead of falling over with the header error.

@swift-ci please clean test

[varungandhi-apple]

Oh boy, I was not expecting this to trigger a crash in the compiler. Filed SR-12824.

[Dimillian]

So basically, we’re actually seeing a regression then 😄

[varungandhi-apple]

It's not clear if it's a regression. For example, we disable assertions in the toolchain shipping in Xcode, but the compiler being used in the tests here has assertions on. I think (not 100% sure) that this is also true for some verifier passes. Since the crash is happening during a verifier pass, it's possible that this issue is present even in shipping toolchains, but it isn't getting triggered because it's off by default. If you want to try it out, you could try building the project using additional compiler flags -Xfrontend -sil-verify-all.

[Dimillian]

Awesome I’ll try, maybe I’m doing something a bit off and I can fix it for this PR to pass.

[Dimillian]

Still passing the build with those flags on Xcode Version 11.4.1 (11E503a)

[varungandhi-apple]

Thanks for checking, then that's probably a regression.

[varungandhi-apple]

Looks like this was just fixed yesterday: swiftlang/swift#31832

@swift-ci please clean test

[Dimillian]

Nice! I'll also update both MovieSwiftUI and this project commit once this PR pass. Quite a lot of more SwiftUI in both projects.

[varungandhi-apple]

The failure right now is when building another project (exercism-swift), not this one. Let's see what needs to be done to fix the exercise-swift issue...

[varungandhi-apple]

Cannot reproduce the exercism-swift issue locally. 😕

@swift-ci please test

[Dimillian]

Maybe one more time ? :p

[xedin]

@swift-ci please test

[Dimillian]

🥳 WOOOOW

[varungandhi-apple]

🚢