Skip to content

Add swift-numerics #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2021
Merged

Add swift-numerics #473

merged 3 commits into from
Jan 14, 2021

Conversation

clackary
Copy link
Contributor

Pull Request Description

Add https://github.com/apple/swift-numerics

Acceptance Criteria

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • pass ./project_precommit_check script run
PASS: swift-numerics, 5.2, ae364a, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-numerics checked successfully against Swift 5.2 ---

@clackary clackary requested a review from shahmishal as a code owner January 11, 2021 23:03
@clackary
Copy link
Contributor Author

@swift-ci test

shahmishal
shahmishal reviewed Jan 11, 2021
View reviewed changes
projects.json
"url": "https://github.com/apple/swift-numerics",
"path": "swift-numerics",
"branch": "main",
"maintainer": "[email protected]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is personal email vs apple email?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using the one listed on GitHub account.

@stephentyrone Do you have a preference for which email is listed here?

@shahmishal
Copy link
Member

Can you also add tag "tags": "swiftpm"?

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@shahmishal This should be ready to merge once it is approved.

@shahmishal shahmishal merged commit 2e7ed8f into main Jan 14, 2021
@shahmishal shahmishal deleted the add-swift-numerics branch January 14, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clackary @shahmishal