Skip to content

Add swift-argument-parser #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Add swift-argument-parser #475

merged 3 commits into from
Jan 12, 2021

Conversation

clackary
Copy link
Contributor

Pull Request Description

Add https://github.com/apple/swift-argument-parser

Acceptance Criteria

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • pass ./project_precommit_check script run
PASS: swift-argument-parser, 5.2, 41f5fe, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-argument-parser checked successfully against Swift 5.2 ---

@clackary clackary requested a review from shahmishal as a code owner January 12, 2021 00:02
@clackary
Copy link
Contributor Author

@natecook1000 FYI - Also adding you as maintainer here! Thanks

@clackary
Copy link
Contributor Author

@swift-ci test

@shahmishal
Copy link
Member

Can you also add tag "tags": "swiftpm"?

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@swift-ci test

@shahmishal
Copy link
Member

This contains only the merge conflict fix, and the previous commit was tested successfully.

Also, json format was verified in the current trigger.

./swift-source-compat-suite/utils/format_projects_list.py swift-source-compat-suite/projects.json

merging the PR.

@shahmishal shahmishal merged commit 95ddc9e into main Jan 12, 2021
@shahmishal shahmishal deleted the add-swift-argument-parser branch January 12, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants