Skip to content

Add swift-atomics #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Add swift-atomics #476

merged 5 commits into from
Jan 27, 2021

Conversation

clackary
Copy link
Contributor

Pull Request Description

Add https://github.com/apple/swift-atomics

Acceptance Criteria

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • pass ./project_precommit_check script run
PASS: swift-atomics, 5.2, df9f81, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-atomics checked successfully against Swift 5.2 ---

@clackary clackary requested a review from shahmishal as a code owner January 12, 2021 00:20
@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@lorentey FYI - Adding you as a maintainer for this! Thanks

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 💯

@shahmishal
Copy link
Member

@lorentey Have you seen this error before?

Full log: https://ci.swift.org/job/swift-PR-source-compat-suite-test-macOS/680/artifact/swift-source-compat-suite/FAIL_swift-atomics_5.2_BuildSwiftPackage.log

/Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/swift-atomics: warning: failed storing manifest for 'swift-atomics' in cache: unknown system error while operating on /Users/buildnode/Library/Caches/org.swift.swiftpm/manifests/manifest.db.lock

@clackary
Copy link
Contributor Author

The previous log looks strange to me, there are a few warnings, but no real error after the swift-frontend command.

warning: failed storing manifest for 'swift-atomics' in cache: unknown system error while operating on /Users/buildnode/Library/Caches/org.swift.swiftpm/manifests/manifest.db.lock

The warning though, makes me wonder if something else caused this to fail. Going to restart testing for now...

@clackary
Copy link
Contributor Author

@swift-ci test

@shahmishal
Copy link
Member

The previous log looks strange to me, there are a few warnings, but no real error after the swift-frontend command.

warning: failed storing manifest for 'swift-atomics' in cache: unknown system error while operating on /Users/buildnode/Library/Caches/org.swift.swiftpm/manifests/manifest.db.lock

The warning though, makes me wonder if something else caused this to fail. Going to restart testing for now...

Looks like the same error I wrote above

@clackary
Copy link
Contributor Author

@swift-ci test

2 similar comments
@shahmishal
Copy link
Member

@swift-ci test

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

@shahmishal I think this should be fine to merge now. The failure in PR testing is coming from swift-futures, which is also failing on the baseline, and swift-atomics built successfully.

@shahmishal
Copy link
Member

Can you please xfail it in baseline?

@clackary
Copy link
Contributor Author

@swift-ci test

@shahmishal shahmishal merged commit 0ad488f into main Jan 27, 2021
@shahmishal shahmishal deleted the add-swift-atomics branch January 27, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants