-
Notifications
You must be signed in to change notification settings - Fork 153
Add swift-atomics #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swift-atomics #476
Conversation
@swift-ci test |
@lorentey FYI - Adding you as a maintainer for this! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 💯
@lorentey Have you seen this error before?
|
The previous log looks strange to me, there are a few warnings, but no real error after the swift-frontend command.
The warning though, makes me wonder if something else caused this to fail. Going to restart testing for now... |
@swift-ci test |
Looks like the same error I wrote above |
@swift-ci test |
@shahmishal I think this should be fine to merge now. The failure in PR testing is coming from swift-futures, which is also failing on the baseline, and swift-atomics built successfully. |
Can you please xfail it in baseline? |
@swift-ci test |
Pull Request Description
Add https://github.com/apple/swift-atomics
Acceptance Criteria
./project_precommit_check
script run