Skip to content

add swift-log #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2021
Merged

add swift-log #478

merged 2 commits into from
Jan 12, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jan 12, 2021 •
edited
Loading

Pull Request Description

Add swift-log to the suite.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
    • 5.0+
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • pass ./project_precommit_check script run
PASS: swift-log, 5.2, 16cfcc, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-log checked successfully against Swift 5.2 ---

@shahmishal
Copy link
Member

@swift-ci test

shahmishal
shahmishal reviewed Jan 12, 2021
View reviewed changes
@ktoso @shahmishal
Update projects.json
f4b654d 
Co-authored-by: Mishal Shah <[email protected]>
ktoso
ktoso commented Jan 12, 2021
View reviewed changes
@ktoso
Copy link
Contributor Author

ktoso commented Jan 12, 2021

@swift-ci test

@ktoso ktoso requested a review from shahmishal January 12, 2021 06:57
shahmishal
shahmishal approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal shahmishal merged commit 652a81c into swiftlang:main Jan 12, 2021
@ktoso ktoso deleted the wip-log branch January 12, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@clackary clackary Awaiting requested review from clackary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @shahmishal