Skip to content

add swift cluster membership #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

add swift cluster membership #480

merged 1 commit into from
Jan 20, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jan 12, 2021

Pull Request Description

add swift cluster membership

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
    • 5.2+ AFAIR
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • Apache License, version 2.0
  • pass ./project_precommit_check script run
PASS: swift-cluster-membership, 5.2, 0fd434, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-cluster-membership checked successfully against Swift 5.2 ---

@shahmishal
Copy link
Member

@swift-ci test

shahmishal
shahmishal approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomerd
Copy link
Contributor

tomerd commented Jan 12, 2021

@ktoso looks like it conflicts now, could you resolve so this can be merged

@ktoso
Copy link
Contributor Author

ktoso commented Jan 12, 2021

@swift-ci test and merge

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Jan 14, 2021

@swift-ci test and merge

@ktoso
Copy link
Contributor Author

ktoso commented Jan 14, 2021

@swift-ci test

@shahmishal
Copy link
Member

@ktoso Can you fix this merge conflict? We dont need to re-run testing, I can merge it after.

@ktoso
Copy link
Contributor Author

ktoso commented Jan 17, 2021

Yes sorry about that, each merge causes a merge conflict in the next PR heh... 🙂

rebased this one now...

@ktoso ktoso requested a review from shahmishal January 17, 2021 02:19
@ktoso
Copy link
Contributor Author

ktoso commented Jan 18, 2021

Since US folks away for 2 more days, lemme test and merge this

@ktoso
Copy link
Contributor Author

ktoso commented Jan 18, 2021

@swift-ci test

@shahmishal shahmishal merged commit 8750d6b into swiftlang:main Jan 20, 2021
@ktoso ktoso deleted the wip-cluster branch January 20, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clackary clackary Awaiting requested review from clackary

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @shahmishal @tomerd