Skip to content

Xfail ReactiveExtensions #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Xfail ReactiveExtensions #496

wants to merge 1 commit into from

Conversation

nkcsgexi
Copy link
Contributor

ReactiveExtensions uses the legacy build system and it failed when we are using the
new driver. The new driver doesn't integrate with the legacy build system.

rdar://75437284

ReactiveExtensions uses the legacy build system and it failed when we are using the
new driver. The new driver doesn't integrate with the legacy build system.

rdar://75437284
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@shahmishal
Copy link
Member

@nkcsgexi Can you file a bug on bugs.swift.org?

@nkcsgexi
Copy link
Contributor Author

@shahmishal to clarify, this is not necessarily a client-side issue. The legacy build system should be able to always pass down -disallow-use-new-driver and these tests will pass.

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Mar 15, 2021

@shahmishal
Copy link
Member

Thanks!

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@shahmishal
Copy link
Member

shahmishal commented Mar 17, 2021

We dont need this change because #497, is that correct @nkcsgexi?

@nkcsgexi
Copy link
Contributor Author

Closing.

@nkcsgexi nkcsgexi closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants