Skip to content

Update GRDB.swift for Swift 5.3 #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

groue
Copy link
Contributor

@groue groue commented Aug 18, 2021

Pull Request Description

Hello, this pull request adds compatibility check for GRDB 5.9.0 and Swift 5.3.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run
$ ./project_precommit_check GRDB.swift --earliest-compatible-swift-version 5.3
** CHECK **
--- Validating GRDB.swift Swift version 5.3 compatibility ---
--- Project configured to be compatible with Swift 5.3 ---
--- Checking GRDB.swift platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check failed ---
Expected version:
Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1200.0.32.28)
Target: x86_64-apple-darwin20.3.0

Current version:
Apple Swift version 5.4.2 (swiftlang-1205.0.28.2 clang-1205.0.19.57)
Target: x86_64-apple-darwin20.6.0

warning: Unexpected swiftc version. Expected swiftc for Swift 5.3 can be found in Xcode 12.4 (contains Swift 5.3.2).
warning: Continuing to build with unexpected swiftc version.

--- Executing build actions ---
$ /Users/groue/Documents/git/groue/swift-source-compat-suite/runner.py --swift-branch swift-5.3-branch --swiftc /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects /Users/groue/Documents/git/groue/swift-source-compat-suite/projects.json --include-repos 'path == "GRDB.swift"' --include-versions 'version == "5.3"' --include-actions 'action.startswith("Build")'
PASS: GRDB.swift, 5.3, d29010, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- GRDB.swift checked successfully against Swift 5.3 ---

@shahmishal
Copy link
Member

@swift-ci test

@groue
Copy link
Contributor Author

groue commented Sep 21, 2021

Hello, is there something I can do in order to help merging this pull request?

@shahmishal
Copy link
Member

  | PASS_GRDB.swift_4.2_BuildSwiftPackage.log 
  | PASS_GRDB.swift_5.0_BuildSwiftPackage.log
  | PASS_GRDB.swift_5.1_BuildSwiftPackage.log
  | PASS_GRDB.swift_5.3_BuildSwiftPackage.log

@shahmishal shahmishal merged commit 655509c into swiftlang:main Sep 21, 2021
groue added a commit to groue/swift-source-compat-suite that referenced this pull request Mar 25, 2023
Also, restore swiftlang#574 which had been reverted for some reason, leaving only support for Swift 4.2 compatibility :-(
@groue groue deleted the GRDB-5.3 branch March 25, 2023 07:58
@groue groue mentioned this pull request Mar 25, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants