Remove invalid versions #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
shahmishal
approved these changes
Oct 27, 2021
xedin
force-pushed
the
remove-invalid-versions
branch
from
20b366a to
847f3ca
Compare
|
@swift-ci please test |
|
Fixed one more 5.1 spot :( |
ahoppen
reviewed
Nov 5, 2021
| @@ -2346,14 +2274,6 @@ | |||
| { | |||
| "version": "4.2", | |||
| "commit": "2fe5b325a8a54e77c545b2f511213420da133b8c" | |||
| }, | |||
There was a problem hiding this comment.
Is it intended that we are only left with the 4.2 branch for Result instead of the 5.1 branch? I think we are now testing compiler main against the 4.2 branch of Result (which is causing a stress tester failure because offsets have moved around).
There was a problem hiding this comment.
Yeah, all of the packages where just defaulting to what either 4 or 5 before and once I added -swift-version support all of the ones I removed started failing with unavailable methods and such, if we want to add swift-version 5 back, need to figure out the commit for it…
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranchbuild_swift_packageto specify expected-swift-version(it was defaulted before)projects.jsonto use only supported Swift versions