Skip to content

Do not clean the Xcode build folder if the action specifies 'clean_bu… #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

rapidsna
Copy link
Contributor

…ild' to be 'false'

Without this fix, GIT command cleaned the build folder even if the
action specified 'clean_build' to be 'false'. This fix allows an
individual action to skip clean when 'clean_build' is explicitly
set 'false'.

Pull Request Description

Replace with a description of this pull request. Instructions for adding
projects are available in the README.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

…ild' to be 'false'

Without this fix, GIT command cleaned the build folder even if the
action specified 'clean_build' to be 'false'. This fix allows an
individual action to skip clean when 'clean_build' is explicitly
set 'false'.
@rapidsna
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapidsna
Copy link
Contributor Author

Thanks @clackary @shahmishal for reviewing!! swift-ci tests failed but the failures don't seem to be related to this change. How do you want me to proceed with this?

@shahmishal shahmishal merged commit 7753675 into main Mar 22, 2022
@shahmishal shahmishal deleted the github/allow_action_skip_clean branch March 22, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants