Skip to content

Un-XFAIL SRP on main now that SR-13190 is fixed #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2022
Merged

Un-XFAIL SRP on main now that SR-13190 is fixed #657

merged 1 commit into from
Apr 16, 2022

Conversation

abertelrud
Copy link
Contributor

@abertelrud abertelrud commented Apr 8, 2022 •
edited
Loading

Now that https://bugs.swift.org/browse/SR-13190 is fixed we get UPASS for the SRP package, so we should remove the XFAIL for main.

@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud force-pushed the eng/un-xfail-srp-package branch from 95a62ad to 412efb2 Compare April 8, 2022 16:04
@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud mentioned this pull request Apr 8, 2022
Merged
@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud
Copy link
Contributor Author

Hmm...

[/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/swift/utils/build-script] ERROR: can't find CMake (please install CMake)
ERROR: command terminated with a non-zero exit status 1, aborting

Traceback (most recent call last):
  File "./swift-source-compat-suite/run", line 325, in <module>
    sys.exit(main())
  File "./swift-source-compat-suite/run", line 38, in main
    build_swift_toolchain(workspace, args)
  File "./swift-source-compat-suite/run", line 293, in build_swift_toolchain
    common.check_execute(build_command, timeout=9999999)
  File "/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/common.py", line 407, in check_execute
    raise ExecuteCommandFailure(command, returncode)
common.ExecuteCommandFailure: ExecuteCommandFailure(command="/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/swift/utils/build-script --preset=source_compat_suite_macos_RA --cmake-c-launcher=/usr/local/bin/sccache --cmake-cxx-launcher=/usr/local/bin/sccache install_destdir=/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/build/compat_macos/install install_prefix=/toolchain/usr install_symroot=/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/build/compat_macos/symroot installable_package=/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/build/compat_macos/root.tar.gz symbols_package=/Users/ec2-user/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/build/compat_macos/root-symbols.tar.gz", returncode=1)

@abertelrud abertelrud force-pushed the eng/un-xfail-srp-package branch from 412efb2 to 76ecd44 Compare April 16, 2022 05:46
@abertelrud abertelrud changed the title Un-XFAIL SRP now that SR-13190 is fixed Un-XFAIL SRP on main now that SR-13190 is fixed Apr 16, 2022
@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud force-pushed the eng/un-xfail-srp-package branch from 76ecd44 to 4433c01 Compare April 16, 2022 05:56
@abertelrud
Un-XFAIL SRP on main with Swift 5 now that SR-13190 is fixed. Non-mai…
89c52ec 
…n still fails, as does Swift 4 (see rdar://91670339)
@abertelrud abertelrud force-pushed the eng/un-xfail-srp-package branch from 4433c01 to 89c52ec Compare April 16, 2022 06:05
@abertelrud
Copy link
Contributor Author

Figured this out. Turns out that it passes with Swift 5 but fails with Swift 4 due to a different bug. Adjusted the XFAIL.

@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud abertelrud requested a review from eeckstein April 16, 2022 06:07
eeckstein
eeckstein approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milseman milseman merged commit e79c27f into main Apr 16, 2022
@milseman milseman deleted the eng/un-xfail-srp-package branch April 16, 2022 13:48
@milseman
Copy link
Member

Merging to unblock CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@clackary clackary Awaiting requested review from clackary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abertelrud @milseman @eeckstein