-
Notifications
You must be signed in to change notification settings - Fork 153
Migrate from Python2 to Python3 #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Labelled as |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
@shahmishal Will merge this today, just one question: I saw some performance degradation when using python 3.7 to test my changes, in particular, things were just taking longer. After profiling the code I saw that the And after updating to 3.9, I no longer saw an issue. The question is: Should we note on the readme that this repository is now targeting python 3.8+, just to be explicit for end-users? If so, I can update this branch quickly to include a change for the readme |
@swift-ci test |
Let's update the README to contain the info, it's ok to do this in new PR. |
Pull Request Description
Updated all Python scrips in the repository to support Python3 and dropped support for Python2. This included
Enum
class for results handlingI also took it upon myself to rename
project_future.py
->project.py
as we originally intendedAcceptance Criteria
Not applicable here