Pass the default process timeout from the main process to the subprocesses that build the projects #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esses that build the projects If we invoke `project_subbilder.build()` immediately on the subprocess, it gets a fresh set of global variables and thus also uses the standard default timeout of 10 minutes, ignoring any timeout that was specified using `--default-timeout`. And 10 minutes is not enough to stress test a project.
ahoppen
requested review from
shahmishal,
clackary and
justice-adams-apple
as code owners
|
@swift-ci Please test |
justice-adams-apple
approved these changes
Aug 10, 2022
|
That’s really interesting. I can’t imagine ACHNBrowserUI finishing stress testing in 10 minutes (it’s more on the order of 2 hours). But anyway, let’s hope it’s fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we invoke
project_subbilder.build()immediately on the subprocess, it gets a fresh set of global variables and thus also uses the standard default timeout of 10 minutes, ignoring any timeout that was specified using--default-timeout. And 10 minutes is not enough to stress test a project.