-
Notifications
You must be signed in to change notification settings - Fork 154
Update Kickstarter/Reactive-Extensions #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updating Master with Latest Commits From Apple
@swift-ci test |
Hi @msadoon , thanks for the PR. A few things: 2.) After that, you will want to remove all the xfail blocks associated with your project since we no longer expect any build failures 😄 . Without removing the xfails, you will get a |
Hi @justice-adams-apple , |
projects.json
Outdated
@@ -1191,11 +1191,11 @@ | |||
"compatibility": [ | |||
{ | |||
"version": "4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes you suggested, but my precommit check for version 4.0 is failing locally with the same hash as for 5.0.
Do I need to rebuild the project in Xcode just for Swift 4.0 and make a commit?
Looks like the new hash for your project is minimum Swift 4.2 compatible. Go ahead and bump the string here from 4.0
to 4.2
and I suspect your build will work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Works, thank you!
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @msadoon !
Pull Request Description
Updating commit hash for building Kickstarter/Reactive-Swift with Swift 5.0.
@swift-ci Please test source compatibility
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_check
script runEnsure project meets all listed requirements before submitting a pull request.