Skip to content

Update Kickstarter/Reactive-Extensions #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented Aug 31, 2022

Pull Request Description

Updating commit hash for building Kickstarter/Reactive-Swift with Swift 5.0.

@swift-ci Please test source compatibility

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@justice-adams-apple
Copy link
Collaborator

@swift-ci test

@justice-adams-apple
Copy link
Collaborator

Hi @msadoon , thanks for the PR. A few things:
1.) You will likely want to update your 4.0 revision as well. Feel free to use the same project revision e3f7786. This will allow you to fix swiftlang/swift#57433 and will ensure your project is tested properly with changes and remains compatible with swift 4.0

2.) After that, you will want to remove all the xfail blocks associated with your project since we no longer expect any build failures 😄 . Without removing the xfails, you will get a UPASS result which will fail the CI build (as what happened here)

@msadoon
Copy link
Contributor Author

msadoon commented Sep 1, 2022

Hi @justice-adams-apple ,
I made the changes you suggested, but my precommit check for version 4.0 is failing locally with the same hash as for 5.0.
Do I need to rebuild the project in Xcode just for Swift 4.0 and make a commit? The previous commit hash passed one test but not the second one.
Just overall curious about how I might start to patch this issue.

projects.json Outdated
@@ -1191,11 +1191,11 @@
"compatibility": [
{
"version": "4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msadoon

I made the changes you suggested, but my precommit check for version 4.0 is failing locally with the same hash as for 5.0.
Do I need to rebuild the project in Xcode just for Swift 4.0 and make a commit?

Looks like the new hash for your project is minimum Swift 4.2 compatible. Go ahead and bump the string here from 4.0 to 4.2 and I suspect your build will work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Works, thank you!

@justice-adams-apple
Copy link
Collaborator

@swift-ci test

Copy link
Collaborator

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @msadoon !

@justice-adams-apple justice-adams-apple merged commit f42b15e into swiftlang:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants