Skip to content

Add Smtp project #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Add Smtp project #791

merged 1 commit into from
Apr 8, 2023

Conversation

clackary
Copy link
Contributor

Pull Request Description

Adds Smtp project to the suite - https://github.com/Mikroservices/Smtp.

Note that a recent compiler regression was discovered when building this project in release mode. swiftlang/swift#64219

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • MIT
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

PASS: Smtp, 5.0, e8f09e, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================

@clackary
Copy link
Contributor Author

Might be a step ahead of myself, but I've added the xfail because the project doesn't currently build in recent toolchains.

@clackary
Copy link
Contributor Author

CC @mczachurski - in case you wanted to keep an eye on this.

Includes an xfail for a known issue: swiftlang/swift#64219
@clackary
Copy link
Contributor Author

Removed the xfail since a fix has landed on main.

@justice-adams-apple
Copy link
Collaborator

@swift-ci test

@shahmishal shahmishal merged commit 9417d2e into swiftlang:main Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants