Use a preset for the build-script invocation used by run_sk_stress_test
#809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/build-with-preset
branch
from
5e8054f to
61efafa
Compare
…est` The hard-coded `build-script` invocation is gross and also didn’t build the new driver, which lead to issues. Use a preset based on the source compat suite presets instead. Effectively, this will add the following arguments to the `build-script` invocation. `--llvm-install-components` and `--swift-install-components` just show the components the newly added components. ``` --cross-compile-hosts=macosx-arm64 --install-llvm \ --install-swift-driver \ --llvm-install-components=clang;clang-resource-headers;compiler-rt;clang-features-file --swift-driver \ --swift-install-components=back-deployment;libexec ```
ahoppen
force-pushed
the
ahoppen/build-with-preset
branch
from
61efafa to
0c33e99
Compare
| ] | ||
| if args.cmake_c_launcher: | ||
| build_command += ['--cmake-c-launcher={}'.format(args.cmake_c_launcher)] |
There was a problem hiding this comment.
should we remove these arguments from the argument parser block of code? I don't think they are used anywhere else (args.cmake_c_launcher, args.cmake_cxx_launcher)
There was a problem hiding this comment.
The stress tester job is passing those, so if we remove them, the innovation would fail. We should remove it in a staged approach:
- Merge this PR so it’s not used anymore
- Change CI jobs to not pass
cmake-c-launcherandcmake-cxx-launcher - Remove
cmake-c-launcherandcmake-cxx-launcherfromrun_sk_stress_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#65706
The hard-coded
build-scriptinvocation is gross and also didn’t build the new driver, which lead to issues. Use a preset based on the source compat suite presets instead.Effectively, this will add the following arguments to the
build-scriptinvocation.--llvm-install-componentsand--swift-install-componentsjust show the components the newly added components.