Support for swiftlang/swift#66540: @_silgen_name on globals, @_silgen_name(raw: ...)

Author: kubamracek

CodeGeneration/Sources/SyntaxSupport/AttributeNodes.swift

@@ -113,6 +113,10 @@ public let ATTRIBUTE_NODES: [Node] = [
             name: "ExposeAttributeArguments",
             kind: .node(kind: .exposeAttributeArguments)
           ),
+          Child(
+            name: "SilgenNameAttributeArguments",
+            kind: .node(kind: .silgenNameAttributeArguments)
+          ),
           Child(
             name: "OriginallyDefinedInArguments",
             kind: .node(kind: .originallyDefinedInArguments)
@@ -608,6 +612,32 @@ public let ATTRIBUTE_NODES: [Node] = [
     ]
   ),
 
+  Node(
+    kind: .silgenNameAttributeArguments,
+    base: .syntax,
+    nameForDiagnostics: "@_silgen_name arguments",
+    documentation: "The arguments for the '@_silgen_name' attribute",
+    children: [
+      Child(
+        name: "Label",
+        kind: .token(choices: [.keyword(text: "raw")]),
+        nameForDiagnostics: "label",
+        documentation: "The label of the argument",
+        isOptional: true
+      ),
+      Child(
+        name: "Colon",
+        kind: .token(choices: [.token(tokenKind: "ColonToken")]),
+        documentation: "The colon separating the label and the value",
+        isOptional: true
+      ),
+      Child(
+        name: "Name",
+        kind: .node(kind: .stringLiteralExpr)
+      ),
+    ]
+  ),
+
   // The argument of '@_implements(...)'
   // implements-attr-arguments -> simple-type-identifier ','
   //                              (identifier | operator) decl-name-arguments

CodeGeneration/Sources/SyntaxSupport/SyntaxNodeKind.swift

@@ -246,6 +246,7 @@ public enum SyntaxNodeKind: String, CaseIterable {
   case returnStmt
   case sameTypeRequirement
   case sequenceExpr
+  case silgenNameAttributeArguments
   case simpleTypeIdentifier
   case sourceFile
   case specializeAttributeSpecList

Sources/SwiftParser/Attributes.swift

@@ -292,10 +292,14 @@ extension Parser {
         }
         return .effectsArguments(RawEffectsArgumentsSyntax(elements: tokens, arena: parser.arena))
       }
-    case ._cdecl, ._silgen_name:
+    case ._cdecl:
       return parseAttribute(argumentMode: .required) { parser in
         return .string(parser.parseStringLiteral())
       }
+    case ._silgen_name:
+      return parseAttribute(argumentMode: .required) { parser in
+        return .silgenNameAttributeArguments(parser.parseSilgenNameArguments())
+      }
     case ._implements:
       return parseAttribute(argumentMode: .required) { parser in
         return .implementsArguments(parser.parseImplementsAttributeArguments())
@@ -938,6 +942,30 @@ extension Parser {
   }
 }
 
+extension Parser {
+  mutating func parseSilgenNameArguments() -> RawSilgenNameAttributeArgumentsSyntax {
+    let label: RawTokenSyntax?
+    let unexpectedBeforeColon: RawUnexpectedNodesSyntax?
+    let colon: RawTokenSyntax?
+    if self.at(.identifier) {
+      label = self.consumeAnyToken()
+      (unexpectedBeforeColon, colon) = self.expect(.colon)
+    } else {
+      label = nil
+      unexpectedBeforeColon = nil
+      colon = nil
+    }
+    let name = self.parseStringLiteral()
+    return RawSilgenNameAttributeArgumentsSyntax(
+      label: label,
+      unexpectedBeforeColon,
+      colon: colon,
+      name: name,
+      arena: self.arena
+    )
+  }
+}
+
 extension Parser {
   mutating func parseOriginallyDefinedInArguments() -> RawOriginallyDefinedInArgumentsSyntax {
     let (unexpectedBeforeModuleLabel, moduleLabel) = self.expect(.keyword(.module))

Sources/SwiftParserDiagnostics/generated/ChildNameForDiagnostics.swift

@@ -306,6 +306,8 @@ private func childNameForDiagnostics(_ keyPath: AnyKeyPath) -> String? {
     return "left-hand type"
   case \SameTypeRequirementSyntax.rightTypeIdentifier:
     return "right-hand type"
+  case \SilgenNameAttributeArgumentsSyntax.label:
+    return "label"
   case \StructDeclSyntax.attributes:
     return "attributes"
   case \StructDeclSyntax.modifiers:

Sources/SwiftParserDiagnostics/generated/SyntaxKindNameForDiagnostics.swift

@@ -339,6 +339,8 @@ extension SyntaxKind {
       return "'return' statement"
     case .sameTypeRequirement:
       return "same type requirement"
+    case .silgenNameAttributeArguments:
+      return "@_silgen_name arguments"
     case .simpleTypeIdentifier:
       return "type"
     case .sourceFile:

Sources/SwiftSyntax/Documentation.docc/generated/SwiftSyntax.md

@@ -356,6 +356,7 @@ These articles are intended for developers wishing to contribute to SwiftSyntax
 - <doc:SwiftSyntax/QualifiedDeclNameSyntax>
 - <doc:SwiftSyntax/ReturnClauseSyntax>
 - <doc:SwiftSyntax/SameTypeRequirementSyntax>
+- <doc:SwiftSyntax/SilgenNameAttributeArgumentsSyntax>
 - <doc:SwiftSyntax/SourceFileSyntax>
 - <doc:SwiftSyntax/SwitchCaseLabelSyntax>
 - <doc:SwiftSyntax/SwitchDefaultLabelSyntax>

Sources/SwiftSyntax/generated/ChildNameForKeyPath.swift

@@ -2833,6 +2833,20 @@ public func childName(_ keyPath: AnyKeyPath) -> String? {
     return "elements"
   case \SequenceExprSyntax.unexpectedAfterElements:
     return "unexpectedAfterElements"
+  case \SilgenNameAttributeArgumentsSyntax.unexpectedBeforeLabel:
+    return "unexpectedBeforeLabel"
+  case \SilgenNameAttributeArgumentsSyntax.label:
+    return "label"
+  case \SilgenNameAttributeArgumentsSyntax.unexpectedBetweenLabelAndColon:
+    return "unexpectedBetweenLabelAndColon"
+  case \SilgenNameAttributeArgumentsSyntax.colon:
+    return "colon"
+  case \SilgenNameAttributeArgumentsSyntax.unexpectedBetweenColonAndName:
+    return "unexpectedBetweenColonAndName"
+  case \SilgenNameAttributeArgumentsSyntax.name:
+    return "name"
+  case \SilgenNameAttributeArgumentsSyntax.unexpectedAfterName:
+    return "unexpectedAfterName"
   case \SimpleTypeIdentifierSyntax.unexpectedBeforeName:
     return "unexpectedBeforeName"
   case \SimpleTypeIdentifierSyntax.name:

Sources/SwiftSyntax/generated/SyntaxAnyVisitor.swift

@@ -1837,6 +1837,14 @@ open class SyntaxAnyVisitor: SyntaxVisitor {
     visitAnyPost(node._syntaxNode)
   }
 
+  override open func visit(_ node: SilgenNameAttributeArgumentsSyntax) -> SyntaxVisitorContinueKind {
+    return visitAny(node._syntaxNode)
+  }
+  
+  override open func visitPost(_ node: SilgenNameAttributeArgumentsSyntax) {
+    visitAnyPost(node._syntaxNode)
+  }
+  
   override open func visit(_ node: SimpleTypeIdentifierSyntax) -> SyntaxVisitorContinueKind {
     return visitAny(node._syntaxNode)
   }

Sources/SwiftSyntax/generated/SyntaxBaseNodes.swift

@@ -910,6 +910,7 @@ extension Syntax {
           .node(ReturnStmtSyntax.self),
           .node(SameTypeRequirementSyntax.self),
           .node(SequenceExprSyntax.self),
+          .node(SilgenNameAttributeArgumentsSyntax.self),
           .node(SimpleTypeIdentifierSyntax.self),
           .node(SourceFileSyntax.self),
           .node(SpecializeAttributeSpecListSyntax.self),

Sources/SwiftSyntax/generated/SyntaxEnum.swift

@@ -238,6 +238,7 @@ public enum SyntaxEnum {
   case returnStmt(ReturnStmtSyntax)
   case sameTypeRequirement(SameTypeRequirementSyntax)
   case sequenceExpr(SequenceExprSyntax)
+  case silgenNameAttributeArguments(SilgenNameAttributeArgumentsSyntax)
   case simpleTypeIdentifier(SimpleTypeIdentifierSyntax)
   case sourceFile(SourceFileSyntax)
   case specializeAttributeSpecList(SpecializeAttributeSpecListSyntax)
@@ -747,6 +748,8 @@ public extension Syntax {
       return .sameTypeRequirement(SameTypeRequirementSyntax(self)!)
     case .sequenceExpr:
       return .sequenceExpr(SequenceExprSyntax(self)!)
+    case .silgenNameAttributeArguments:
+      return .silgenNameAttributeArguments(SilgenNameAttributeArgumentsSyntax(self)!)
     case .simpleTypeIdentifier:
       return .simpleTypeIdentifier(SimpleTypeIdentifierSyntax(self)!)
     case .sourceFile:

Sources/SwiftSyntax/generated/SyntaxKind.swift

@@ -238,6 +238,7 @@ public enum SyntaxKind {
   case returnStmt
   case sameTypeRequirement
   case sequenceExpr
+  case silgenNameAttributeArguments
   case simpleTypeIdentifier
   case sourceFile
   case specializeAttributeSpecList
@@ -866,6 +867,8 @@ public enum SyntaxKind {
       return SameTypeRequirementSyntax.self
     case .sequenceExpr:
       return SequenceExprSyntax.self
+    case .silgenNameAttributeArguments:
+      return SilgenNameAttributeArgumentsSyntax.self
     case .simpleTypeIdentifier:
       return SimpleTypeIdentifierSyntax.self
     case .sourceFile:

Sources/SwiftSyntax/generated/SyntaxRewriter.swift

@@ -1586,6 +1586,13 @@ open class SyntaxRewriter {
     return ExprSyntax(visitChildren(node))
   }
 
+  /// Visit a ``SilgenNameAttributeArgumentsSyntax``.
+  ///   - Parameter node: the node that is being visited
+  ///   - Returns: the rewritten node
+  open func visit(_ node: SilgenNameAttributeArgumentsSyntax) -> SilgenNameAttributeArgumentsSyntax {
+    return Syntax(visitChildren(node)).cast(SilgenNameAttributeArgumentsSyntax.self)
+  }
+  
   /// Visit a ``SimpleTypeIdentifierSyntax``.
   ///   - Parameter node: the node that is being visited
   ///   - Returns: the rewritten node
@@ -5167,6 +5174,20 @@ open class SyntaxRewriter {
     return Syntax(visit(node))
   }
 
+  /// Implementation detail of visit(_:). Do not call directly.
+  private func visitImplSilgenNameAttributeArgumentsSyntax(_ data: SyntaxData) -> Syntax {
+    let node = SilgenNameAttributeArgumentsSyntax(data)
+    // Accessing _syntaxNode directly is faster than calling Syntax(node)
+    visitPre(node._syntaxNode)
+    defer {
+      visitPost(node._syntaxNode)
+    }
+    if let newNode = visitAny(node._syntaxNode) {
+      return newNode
+    }
+    return Syntax(visit(node))
+  }
+  
   /// Implementation detail of visit(_:). Do not call directly.
   private func visitImplSimpleTypeIdentifierSyntax(_ data: SyntaxData) -> Syntax {
     let node = SimpleTypeIdentifierSyntax(data)
@@ -6425,6 +6446,8 @@ open class SyntaxRewriter {
       return visitImplSameTypeRequirementSyntax
     case .sequenceExpr:
       return visitImplSequenceExprSyntax
+    case .silgenNameAttributeArguments:
+      return visitImplSilgenNameAttributeArgumentsSyntax
     case .simpleTypeIdentifier:
       return visitImplSimpleTypeIdentifierSyntax
     case .sourceFile:
@@ -6991,6 +7014,8 @@ open class SyntaxRewriter {
       return visitImplSameTypeRequirementSyntax(data)
     case .sequenceExpr:
       return visitImplSequenceExprSyntax(data)
+    case .silgenNameAttributeArguments:
+      return visitImplSilgenNameAttributeArgumentsSyntax(data)
     case .simpleTypeIdentifier:
       return visitImplSimpleTypeIdentifierSyntax(data)
     case .sourceFile:

Sources/SwiftSyntax/generated/SyntaxTransform.swift

@@ -1134,6 +1134,11 @@ public protocol SyntaxTransformVisitor {
   ///   - Returns: the sum of whatever the child visitors return.
   func visit(_ node: SequenceExprSyntax) -> ResultType
 
+  /// Visiting ``SilgenNameAttributeArgumentsSyntax`` specifically.
+  ///   - Parameter node: the node we are visiting.
+  ///   - Returns: the sum of whatever the child visitors return.
+  func visit(_ node: SilgenNameAttributeArgumentsSyntax) -> ResultType
+  
   /// Visiting ``SimpleTypeIdentifierSyntax`` specifically.
   ///   - Parameter node: the node we are visiting.
   ///   - Returns: the sum of whatever the child visitors return.
@@ -2976,6 +2981,13 @@ extension SyntaxTransformVisitor {
     visitAny(Syntax(node))
   }
 
+  /// Visiting ``SilgenNameAttributeArgumentsSyntax`` specifically.
+  ///   - Parameter node: the node we are visiting.
+  ///   - Returns: nil by default.
+  public func visit(_ node: SilgenNameAttributeArgumentsSyntax) -> ResultType {
+    visitAny(Syntax(node))
+  }
+  
   /// Visiting ``SimpleTypeIdentifierSyntax`` specifically.
   ///   - Parameter node: the node we are visiting.
   ///   - Returns: nil by default.
@@ -3811,6 +3823,8 @@ extension SyntaxTransformVisitor {
       return visit(derived)
     case .sequenceExpr(let derived):
       return visit(derived)
+    case .silgenNameAttributeArguments(let derived):
+      return visit(derived)
     case .simpleTypeIdentifier(let derived):
       return visit(derived)
     case .sourceFile(let derived):

Sources/SwiftSyntax/generated/SyntaxVisitor.swift

@@ -2710,6 +2710,18 @@ open class SyntaxVisitor {
   open func visitPost(_ node: SequenceExprSyntax) {
   }
 
+  /// Visiting ``SilgenNameAttributeArgumentsSyntax`` specifically.
+  ///   - Parameter node: the node we are visiting.
+  ///   - Returns: how should we continue visiting.
+  open func visit(_ node: SilgenNameAttributeArgumentsSyntax) -> SyntaxVisitorContinueKind {
+    return .visitChildren
+  }
+  
+  /// The function called after visiting ``SilgenNameAttributeArgumentsSyntax`` and its descendents.
+  ///   - node: the node we just finished visiting.
+  open func visitPost(_ node: SilgenNameAttributeArgumentsSyntax) {
+  }
+  
   /// Visiting ``SimpleTypeIdentifierSyntax`` specifically.
   ///   - Parameter node: the node we are visiting.
   ///   - Returns: how should we continue visiting.
@@ -5835,6 +5847,17 @@ open class SyntaxVisitor {
     visitPost(node)
   }
 
+  /// Implementation detail of doVisit(_:_:). Do not call directly.
+  private func visitImplSilgenNameAttributeArgumentsSyntax(_ data: SyntaxData) {
+    let node = SilgenNameAttributeArgumentsSyntax(data)
+    let needsChildren = (visit(node) == .visitChildren)
+    // Avoid calling into visitChildren if possible.
+    if needsChildren && !node.raw.layoutView!.children.isEmpty {
+      visitChildren(node)
+    }
+    visitPost(node)
+  }
+  
   /// Implementation detail of doVisit(_:_:). Do not call directly.
   private func visitImplSimpleTypeIdentifierSyntax(_ data: SyntaxData) {
     let node = SimpleTypeIdentifierSyntax(data)
@@ -6893,6 +6916,8 @@ open class SyntaxVisitor {
       visitImplSameTypeRequirementSyntax(data)
     case .sequenceExpr:
       visitImplSequenceExprSyntax(data)
+    case .silgenNameAttributeArguments:
+      visitImplSilgenNameAttributeArgumentsSyntax(data)
     case .simpleTypeIdentifier:
       visitImplSimpleTypeIdentifierSyntax(data)
     case .sourceFile: