Allow @_silgen_name to be used on globals and add a @_silgen_name(raw: ...) version that skips mangling #66540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
It isn't safe to export the symbol of a global generally because anyone directly accessing it would bypass the one-time initializer, which is why this hasn't been allowed yet. If |
|
@jckarter Added a check that rejects |
jckarter
approved these changes
Jun 26, 2023
kubamracek
added a commit
to swiftlang/swift-syntax
that referenced
this pull request
Jun 26, 2023
…_name(raw: ...)
|
Please test with following pull request: @swift-ci Please test |
…: ...) version that skips mangling
kubamracek
added a commit
to swiftlang/swift-syntax
that referenced
this pull request
Jun 28, 2023
…_name(raw: ...)
kubamracek
force-pushed
the
silgen-name-for-globals
branch
from
6e4863b to
ecfeb1d
Compare
|
Please test with following pull request: @swift-ci Please test |
|
Please test with following pull request: @swift-ci Please test |
kubamracek
added a commit
to swiftlang/swift-syntax
that referenced
this pull request
Jun 29, 2023
Support for swiftlang/swift#66540: @_silgen_name on globals, @_silgen_name(raw: ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute @_silgen_name is today only allowed to be used on functions, this PR allows usage on globals as well. The motivation for that is to be able to "forward declare" globals just like it's today possible to do with functions (for the cases where it's not practical or convenient to use a bridging header).
Separately, this PR also adds a
@_silgen_name(raw: ...)syntax, which simply avoids mangling the name (by using the\01name prefix that LLVM uses). The motivation for that is to be able to reference the "magic Darwin linker symbols" that can be used to look up section bounds (in the current dylib/module) -- those symbols don't use the underscore prefix in their mangled names. The attached testcases showcase this as a low-level "linker set" implementation.