Merge pull request #1850 from apple/mracek/silgen-name-for-globals

Support for swiftlang/swift#66540: @_silgen_name on globals, @_silgen_name(raw: ...)

Author: kubamracek

CodeGeneration/Sources/SyntaxSupport/KeywordSpec.swift

@@ -73,7 +73,6 @@ public let KEYWORDS: [KeywordSpec] = [
   KeywordSpec("_read"),
   KeywordSpec("_RefCountedObject"),
   KeywordSpec("_semantics"),
-  KeywordSpec("_silgen_name"),
   KeywordSpec("_specialize"),
   KeywordSpec("_spi"),
   KeywordSpec("_spi_available"),

Sources/SwiftParser/Attributes.swift

@@ -47,7 +47,6 @@ extension Parser {
     case _private
     case _projectedValueProperty
     case _semantics
-    case _silgen_name
     case _specialize
     case _spi
     case _spi_available
@@ -82,7 +81,6 @@ extension Parser {
       case TokenSpec(._private): self = ._private
       case TokenSpec(._projectedValueProperty): self = ._projectedValueProperty
       case TokenSpec(._semantics): self = ._semantics
-      case TokenSpec(._silgen_name): self = ._silgen_name
       case TokenSpec(._specialize): self = ._specialize
       case TokenSpec(._spi): self = ._spi
       case TokenSpec(._spi_available): self = ._spi_available
@@ -121,7 +119,6 @@ extension Parser {
       case ._private: return .keyword(._private)
       case ._projectedValueProperty: return .keyword(._projectedValueProperty)
       case ._semantics: return .keyword(._semantics)
-      case ._silgen_name: return .keyword(._silgen_name)
       case ._specialize: return .keyword(._specialize)
       case ._spi: return .keyword(._spi)
       case ._spi_available: return .keyword(._spi_available)
@@ -292,7 +289,7 @@ extension Parser {
         }
         return .effectsArguments(RawEffectsArgumentsSyntax(elements: tokens, arena: parser.arena))
       }
-    case ._cdecl, ._silgen_name:
+    case ._cdecl:
       return parseAttribute(argumentMode: .required) { parser in
         return .string(parser.parseStringLiteral())
       }

Sources/SwiftSyntax/generated/Keyword.swift

@@ -49,7 +49,6 @@ public enum Keyword: UInt8, Hashable {
   case _read
   case _RefCountedObject
   case _semantics
-  case _silgen_name
   case _specialize
   case _spi
   case _spi_available
@@ -617,8 +616,6 @@ public enum Keyword: UInt8, Hashable {
         self = ._NativeClass
       case "_nonSendable":
         self = ._nonSendable
-      case "_silgen_name":
-        self = ._silgen_name
       case "availability":
         self = .availability
       case "backDeployed":
@@ -798,7 +795,6 @@ public enum Keyword: UInt8, Hashable {
       "_read", 
       "_RefCountedObject", 
       "_semantics", 
-      "_silgen_name", 
       "_specialize", 
       "_spi", 
       "_spi_available", 

Tests/SwiftParserTest/AttributeTests.swift

@@ -393,6 +393,18 @@ final class AttributeTests: XCTestCase {
       @_silgen_name("") func foo() {}
       """
     )
+
+    assertParse(
+      """
+      @_silgen_name("foo") var global: Int
+      """
+    )
+
+    assertParse(
+      """
+      @_silgen_name(raw: "foo") var global: Int
+      """
+    )
   }
 
   func testBackDeployed() {