Merge pull request #710 from MEnnabah/specialize-attribute-invalid-param

Fixes #679: @Specialize with invalid attribute

Author: CodaFi

Sources/SwiftParser/Attributes.swift

@@ -491,11 +491,9 @@ extension Parser {
   mutating func parseSpecializeAttributeSpecList() -> RawSpecializeAttributeSpecListSyntax {
     var elements = [RawSyntax]()
     // Parse optional "exported" and "kind" labeled parameters.
-    while !self.at(.eof) && !self.at(.whereKeyword) {
+    while !self.at(.eof) && !self.at(.rightParen) && !self.at(.whereKeyword) {
       let ident = self.parseAnyIdentifier()
-      guard let knownParameter = SpecializeParameter(rawValue: ident.tokenText) else {
-        fatalError()
-      }
+      let knownParameter = SpecializeParameter(rawValue: ident.tokenText)
       let (unexpectedBeforeColon, colon) = self.expect(.colon)
 
       switch knownParameter {
@@ -573,6 +571,17 @@ extension Parser {
           trailingComma: comma,
           arena: self.arena
         )))
+      case nil:
+        let valueLabel = self.consumeAnyToken()
+        let comma = self.consume(if: .comma)
+        elements.append(RawSyntax(RawLabeledSpecializeEntrySyntax(
+          label: ident,
+          unexpectedBeforeColon,
+          colon: colon,
+          value: valueLabel,
+          trailingComma: comma,
+          arena: self.arena
+        )))
       }
     }
 

Tests/SwiftParserTest/Attributes.swift

@@ -32,4 +32,29 @@ final class AttributeTests: XCTestCase {
       ]
     )
   }
+  
+  func testMissingClosingParenToAttribute() {
+    AssertParse(
+      """
+      @_specialize(e#^DIAG_1^#
+      """,
+      diagnostics: [
+        DiagnosticSpec(locationMarker: "DIAG_1", message: "Expected ':' in attribute argument"),
+        DiagnosticSpec(locationMarker: "DIAG_1", message: "Expected ')' to end attribute"),
+      ]
+    )
+  }
+  
+  func testMultipleInvalidSpecializeParams() {
+    AssertParse(
+      """
+      @_specialize(e#^DIAG_1^#, exported#^DIAG_2^#)
+      """,
+      diagnostics: [
+        DiagnosticSpec(locationMarker: "DIAG_1", message: "Expected ':' in attribute argument"),
+        DiagnosticSpec(locationMarker: "DIAG_2", message: "Expected ':' in attribute argument"),
+        DiagnosticSpec(locationMarker: "DIAG_2", message: "Expected 'false' in attribute argument"),
+      ]
+    )
+  }
 }