Fixes #679: @specialize with invalid attribute #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Sep 5, 2022
| @@ -573,6 +571,15 @@ extension Parser { | |||
| trailingComma: comma, | |||
| arena: self.arena | |||
| ))) | |||
| case .none: | |||
| let valueLabel = self.consumeAnyToken() | |||
There was a problem hiding this comment.
Let's try to parse a trailing comma here just in case the user wrote
@_specialize(e, exported: true)
or something.
There was a problem hiding this comment.
Thanks for the feedback Robert! I've pushed another commit.
|
@swift-ci test |
CodaFi
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #679.
The solution suggests that the
@_specializeparameter is missing a colon (i.e.Expected ':' in attribute argument). This is only true for parameters ofSpecializeParameterenum.However, I believe this behaviour is incorrect in case of supplying a type as a parameter (E.g.
@_specialize(T == Int)), because it won't have a colon.The previous example is from
@_specializeattribute pitch, where it seems it's possible to define a parameter with a type only, as opposed to the current unit tests inSwiftParserTestwhere the type parameters are only defined with awhereclause (E.g.@_specialize(where T.Element == Int)).So I'm not 100% sure about the possibility of supplying the type only without a
whereclause.