Merge pull request #567 from ahoppen/pr/syntaxviewingmode-all-is-public

Remove underscore from SyntaxViewingMode._all

Author: ahoppen

Sources/SwiftSyntax/Syntax.swift

@@ -540,7 +540,7 @@ public extension SyntaxProtocol {
       target.write(String(describing: syntaxNodeType))
     }
 
-    let allChildren = children(viewMode: ._all)
+    let allChildren = children(viewMode: .all)
     if includeChildren {
       if !allChildren.isEmpty {
         target.write(" children=\(allChildren.count)")

Sources/SwiftSyntax/SyntaxTreeViewMode.swift

@@ -25,9 +25,7 @@ public enum SyntaxTreeViewMode {
   case fixedUp
 
   /// Both missing and garbage nodes will be traversed.
-  /// Mostly useful for SwiftSyntax internal verifiers that verify the integrity
-  /// of the entire tree
-  case _all
+  case all
 
   /// Returns whether this traversal node should visit `node` or ignore it.
   func shouldTraverse(node: RawSyntax) -> Bool {
@@ -36,7 +34,7 @@ public enum SyntaxTreeViewMode {
       return node.presence == .present
     case .fixedUp:
       return node.kind != .garbageNodes
-    case ._all:
+    case .all:
       return true
     }
   }

Sources/SwiftSyntax/SyntaxVerifier.swift

@@ -31,7 +31,7 @@ public class SyntaxVerifier: SyntaxAnyVisitor {
   var unknownNodes: [Syntax] = []
 
   init() {
-    super.init(viewMode: ._all)
+    super.init(viewMode: .all)
   }
 
   public override func visitAny(_ node: Syntax) -> SyntaxVisitorContinueKind {

Sources/_SwiftSyntaxTestSupport/Syntax+Assertions.swift

@@ -237,7 +237,7 @@ fileprivate class SyntaxTypeFinder: SyntaxAnyVisitor {
     self.offset = offset
     self.type = type
     self.found = nil
-    super.init(viewMode: ._all)
+    super.init(viewMode: .all)
   }
 
   fileprivate override func visitAny(_ node: Syntax) -> SyntaxVisitorContinueKind {

Sources/_SwiftSyntaxTestSupport/SyntaxComparison.swift

@@ -94,8 +94,8 @@ public extension SyntaxProtocol {
       return TreeDifference(node: self, baseline: baseline, reason: reason)
     }
 
-    var iterator = children(viewMode: ._all).makeIterator()
-    var baseIterator = baseline.children(viewMode: ._all).makeIterator()
+    var iterator = children(viewMode: .all).makeIterator()
+    var baseIterator = baseline.children(viewMode: .all).makeIterator()
     while let child = iterator.next() {
       guard let baselineChild = baseIterator.next() else {
         return TreeDifference(node: child, baseline: baseline, reason: .additionalNode)

Sources/lit-test-helper/main.swift

@@ -528,7 +528,7 @@ func diagnose(args: CommandLineArguments) throws {
     init(diagnosticHandler: @escaping ((Diagnostic) -> Void), _ converter: SourceLocationConverter) {
       self.diagnosticHandler = diagnosticHandler
       self.converter = converter
-      super.init(viewMode: ._all)
+      super.init(viewMode: .all)
     }
     override func visitAny(_ node: Syntax) -> SyntaxVisitorContinueKind {
       if node.isUnknown {