Remove underscore from SyntaxViewingMode._all #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 9, 2022
bnbarham
reviewed
Aug 9, 2022
Comment on lines
28
to
29
| /// Mostly useful for SwiftSyntax internal verifiers that verify the integrity | ||
| /// of the entire tree |
There was a problem hiding this comment.
Is this comment still true?
There was a problem hiding this comment.
Good catch. I think we should get rid of it.
I believe this syntax viewing mode can be useful in general and there’s no need to make it semi-private with an underscore. rdar://98368959
ahoppen
force-pushed
the
pr/syntaxviewingmode-all-is-public
branch
from
33687de to
4fd05f2
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this syntax viewing mode can be useful in general and there’s no need to make it semi-private with an underscore.
rdar://98368959