Change SyntaxRewriter to disallow type node type conversions for all types that are not ExprSyntax, StmtSyntax … #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types that are not ExprSyntax, StmtSyntax … Intuitively, changing the kind of an expression in a rewriter makes sense but for all the other syntax kinds I can’t see any use case for changing their types. Thus, add some type safety to `SyntaxRewriter` by requiring that all `visit` methods for nodes that don’t have a base kind like `ExprSyntax` return a node of the same type. rdar://101355004
|
Here’s the PR to update swift-format. In general it appears to clean things up in there: swiftlang/swift-format#433 |
bnbarham
approved these changes
Oct 21, 2022
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intuitively, changing the kind of an expression in a rewriter makes sense but for all the other syntax kinds I can’t see any use case for changing their types.
Thus, add some type safety to
SyntaxRewriterby requiring that allvisitmethods for nodes that don’t have a base kind likeExprSyntaxreturn a node of the same type.rdar://101355004