Add a convenience initializer to combine unexpected nodes #1005
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
I find this better than what we have, but I was honestly less concerned with the mapping/combining and more concerned with the fact we create nodes that we then just drop on the floor (but keep in memory). I know this doesn't really matter, it's just the principle of it all 😅.
| // MARK: Combining unexpected nodes | ||
|
|
||
| /// Implementation detail of `RawUnexpectedNodesSyntax.init(combining:arena)`. | ||
| protocol UnexpectedNodsCombinable { |
There was a problem hiding this comment.
Suggested change
| protocol UnexpectedNodsCombinable { | |
| protocol UnexpectedNodesCombinable { |
ahoppen
force-pushed
the
ahoppen/combine-unexpected
branch
from
4121ce3 to
877ae05
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/combine-unexpected
branch
from
877ae05 to
11595d1
Compare
ahoppen
force-pushed
the
ahoppen/combine-unexpected
branch
from
11595d1 to
631d5c5
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #998 (comment)