Speed-up lookups for incremental re-parsing #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the search for nodes to re-use was naively doing a lookup that always started from the top of the tree, every time the parser called back. The new mechanism takes advantage of the fact that the parser continuously calls back with ascending source positions, not random ones, and keeps a "cursor" state for re-starting the lookup search from the last node position. This commit also introduces `SyntaxNode` which is a more efficient representation for a syntax tree node, that `SyntaxParser` uses to efficiently report which syntax nodes got re-used during incremental re-parsing. Changes result in improved performance for incremental reparsing. When using the test case from rdar://48511326, performance improves by 321x.
|
@swift-ci Please test |
nkcsgexi
approved these changes
Mar 4, 2019
harlanhaskins
approved these changes
Mar 4, 2019
|
I've noticed that Also noticed that (sometimes) May it be due to this change? |
|
This PR is unrelated to what you are describing in SR-10074 |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Support tab based indentation in the whitespace linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the search for nodes to re-use was naively doing a lookup that always started from the top of the tree, every time the parser called back.
The new mechanism takes advantage of the fact that the parser continuously calls back with ascending source positions, not random ones, and keeps a "cursor" state for re-starting the lookup search from the last node position.
This commit also introduces
SyntaxNodewhich is a more efficient representation for a syntax tree node, thatSyntaxParseruses to efficiently report which syntax nodes got re-used during incremental re-parsing.Changes result in improved performance for incremental reparsing. When using the test case from rdar://48511326, performance improves by 321x.