Add SwiftSyntaxBuilder convenience initializers that mix parser integration and result builders #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/convenience-inits-mixing-string-and-result-builder
branch
from
81f9396 to
fa34bdb
Compare
|
@swift-ci Please test |
kimdv
reviewed
Oct 25, 2022
kimdv
reviewed
Oct 25, 2022
Comment on lines
+19
to
+20
| let buildable = ProtocolDecl("public protocol DeclListBuildable") { | ||
| FunctionDecl("func buildDeclList(format: Format, leadingTrivia: Trivia?) -> [DeclSyntax]") |
kimdv
reviewed
Oct 25, 2022
Comment on lines
+21
to
+23
| SwitchCase("case \(num):") { | ||
| Expr("print(count)") | ||
| } |
kimdv
approved these changes
Oct 25, 2022
…ration and result builders
…ion:)` convenience initializer
ahoppen
force-pushed
the
ahoppen/convenience-inits-mixing-string-and-result-builder
branch
from
6cd8020 to
8e1c49c
Compare
|
@swift-ci Please test |
ahoppen
deleted the
ahoppen/convenience-inits-mixing-string-and-result-builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important use case of this is that we now allow things like
Previously, the syntax tree for the signature had to be created manually.
While I was touching the convenience initializers, I merged them into a single file (which makes them easier to navigate IMO)
ahoppen@fe30a08 contains the corresponding changes to adopt these initializers in CodeGeneration.