[Macros] Support user-defined macros as compiler plugins #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#61734 |
|
swiftlang/swift#61734 |
1 similar comment
|
swiftlang/swift#61734 |
DougGregor
approved these changes
Oct 27, 2022
rxwei
force-pushed
the
macro-compiler-plugin
branch
from
c1c4edf to
0b70207
Compare
|
swiftlang/swift#61734 |
|
@swift-ci please test |
DougGregor
approved these changes
Oct 28, 2022
| guard let meeStartToken = sourceFileSyntax.token(at: meePosition), | ||
| let mee = meeStartToken.parent?.as(MacroExpansionExprSyntax.self) | ||
| else { | ||
| fatalError("Unable to locate 'MacroExpansionExprSyntax'") |
There was a problem hiding this comment.
It makes me pretty nervous to have a fatalError in something that will be in the compiler process. In some follow-up PR, can you find a way to report the failure back out of this API?
There was a problem hiding this comment.
Yes I'll find a way to allow diagnostics to be reported back
Make `Macro` refine `_CompilerPlugin` protocol when `_CompilerPluginSupport` exists. (`_CompilerPluginSupport` may not exist when ASTGen or SwiftCompilerSources is built with host tools.) This enables macros to talk to the compiler without an ABI-stable SwiftSyntax.
rxwei
force-pushed
the
macro-compiler-plugin
branch
from
0b70207 to
e3d2622
Compare
|
@swift-ci please test |
rxwei
added a commit
to swiftlang/swift
that referenced
this pull request
Oct 31, 2022
Allow user-defined macros to be loaded from dynamic libraries and evaluated. - Introduce a _CompilerPluginSupport module installed into the toolchain. Its `_CompilerPlugin` protocol acts as a stable interface between the compiler and user-defined macros. - Introduce a `-load-plugin-library <path>` attribute which allows users to specify dynamic libraries to be loaded into the compiler. A macro library must declare a public top-level computed property `public var allMacros: [Any.Type]` and be compiled to a dynamic library. The compiler will call the getter of this property to obtain and register all macros. Known issues: - We current do not have a way to strip out unnecessary symbols from the plugin dylib, i.e. produce a plugin library that does not contain SwiftSyntax symbols that will collide with the compiler itself. - `MacroExpansionExpr`'s type is hard-coded as `(Int, String)`. It should instead be specified by the macro via protocol requirements such as `signature` and `genericSignature`. We need more protocol requirements in `_CompilerPlugin` to handle this. - `dlopen` is not secure and is only for prototyping use here. Friend PR: swiftlang/swift-syntax#1022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Macrorefine_CompilerPluginprotocol when_CompilerPluginSupportexists. (_CompilerPluginSupportmay not exist when ASTGen or SwiftCompilerSources is built with host tools.) This enables macros to talk to the compiler without an ABI-stable SwiftSyntax.Friend PR: swiftlang/swift#61734