Don’t eat closing braces while trying to recover to a declaration start keyword #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
reviewed
Oct 26, 2022
Comment on lines
79
to
80
| let baselineRootConverter = SourceLocationConverter(file: "Baseline.swift", source: baseline.root.description) | ||
| let nodeRootConverter = SourceLocationConverter(file: "Actual.swift", source: node.root.description) |
There was a problem hiding this comment.
May as well use these when printing the nodes above as well?
bnbarham
reviewed
Oct 26, 2022
Comment on lines
+163
to
+164
| || fileURL.absoluteString.contains("26190-swift-iterabledeclcontext-getmembers.swift") | ||
| || fileURL.absoluteString.contains("26139-swift-abstractclosureexpr-setparams.swift") |
There was a problem hiding this comment.
These aren't even that bad, pretty surprising to me that they cause a stack overflow. Isn't even 100 nested braces!
There was a problem hiding this comment.
The issue here appears to be debug builds. In release builds, these are just fine.
This was caused by the latest SwiftSyntaxBuilder API update
ahoppen
force-pushed
the
ahoppen/no-nested-class-recovery
branch
from
e2bd89e to
2e7b363
Compare
|
@swift-ci please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when given
recovery to the second
class(because^is unexpected) would also consume the closing}nestingBinsideA. That’s unexpected. Recovery of decl keywords inside member decl lists should not consume closing braces.While doing this, also fix a few miscellaneous bugs in the test infrastructure.